+++ This bug was initially created as a clone of Bug #172669 +++ From Bugzilla Helper: User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.12) Gecko/20050922 Fedora/1.0.7-1.1.fc4 Firefox/1.0.7 Description of problem: The latest update to cpio is being killed after a buffer overflow is detected. Version-Release number of selected component (if applicable): cpio-2.6-8.FC4 How reproducible: Always Steps to Reproduce: cpio is given a large hierarchy of files and started using "cpio -o --format=crc" -- Additional comment from arjanv on 2005-11-10 09:03 EST -- char ascii_header[112]; ... sprintf (ascii_header, "%6s%08lx%08lx%08lx%08lx%08lx%08lx%08lx%08lx%08lx%08lx%08lx%08lx%08lx", magic_string, file_hdr->c_ino, file_hdr->c_mode, file_hdr->c_uid, file_hdr->c_gid, file_hdr->c_nlink, file_hdr->c_mtime, file_hdr->c_filesize, file_hdr->c_dev_maj, file_hdr->c_dev_min, file_hdr->c_rdev_maj, file_hdr->c_rdev_min, file_hdr->c_namesize, file_hdr->c_chksum); ... cpio assumes the filesize is at most 8 digits in size... and that's not right. If it's more, this buffer will indeed overflow.... this probably wants to use asprintf() or so -- Additional comment from bressers on 2005-11-10 13:07 EST -- Please note that this is only a security issue on 64 bit platforms. This issue should also affect RHEL2.1 and RHEL3
Created attachment 130020 [details] patch extracted from upstream This patch could fix also #183224, but it's necessary to rewrite cpio-2.5-lfs.patch. Than there will be 3 issues addressed: #172865, #183224, cpio will be able to archive files <8GB in odc format.(no bz report for this) Is it possible to do these changes? Everything is tested and works in FC-5. I'd like to do it at once to avoid any other problem which come if only writeOutHeaderBufferOverflow.patch is applied
QE ack for 4.5.
+ static char codetab[] = "0123456789ABCDEF"; Should have const in that line.
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on the solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2007-0245.html