Bug 172870 - Review Request: fdupes
Summary: Review Request: fdupes
Keywords:
Status: CLOSED DUPLICATE of bug 173080
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Adrian Reber
QA Contact: David Lawrence
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2005-11-10 19:10 UTC by Bastien Nocera
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-11-18 09:29:42 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)
spec patch (961 bytes, patch)
2005-11-11 17:14 UTC, Adrian Reber 		no flags Details | Diff
spec patch (1.45 KB, patch)
2005-11-11 17:29 UTC, Adrian Reber 		no flags Details | Diff
Show Obsolete (1) View All

Description Bastien Nocera 2005-11-10 19:10:29 UTC 
Spec Name or Url: http://files.hadess.net/redhat/perso/spec/fdupes.spec
SRPM Name or Url: http://files.hadess.net/redhat/perso/source/fdupes-1.40-1.src.rpm
Description:
FDUPES is a program for identifying or deleting duplicate files residing
within specified directories.
Comment 1 Adrian Reber 2005-11-11 17:10:50 UTC 
Will also attach a patch.

Another problem is that fdupes is not GPL as the spec files claims it to be.
Comment 2 Adrian Reber 2005-11-11 17:14:29 UTC 
Created attachment 120952 [details]
spec patch

Changes:
- Group didn't exist
- BR were bogus
- BuildRoot changed
- honour RPM_OPT_FLAGS
- using macros not hardcoded paths
- added -p to install to preserve timestamps
- consistent use of RPM_BUILD_ROOT
- correct version in changelog
Comment 3 Bastien Nocera 2005-11-11 17:25:15 UTC 
You uploaded the .spec file directly, which has no changes compared to mine...
Comment 4 Adrian Reber 2005-11-11 17:29:15 UTC 
Created attachment 120954 [details]
spec patch

another try
Comment 5 Adrian Reber 2005-11-17 18:34:19 UTC 
So can this be closed if Simon in
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173080 maintains this?
Comment 6 Bastien Nocera 2005-11-18 09:29:42 UTC 
Sure thing.

*** This bug has been marked as a duplicate of 173080 ***
Note You need to log in before you can comment on or make changes to this bug.