Bug 1729430 - rpm2flatpak: Do not hardcode sysconfdir to /etc
Summary: rpm2flatpak: Do not hardcode sysconfdir to /etc
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: udisks2
Version: 30
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Vojtech Trefny
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-07-12 09:06 UTC by Milan Crha
Modified: 2019-08-08 00:55 UTC (History)
3 users (show)

Fixed In Version: udisks2-2.8.4-1.fc30
Clone Of:
Environment:
Last Closed: 2019-08-08 00:55:10 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
proposed patch (371 bytes, patch)
2019-07-12 09:06 UTC, Milan Crha
no flags Details | Diff

Description Milan Crha 2019-07-12 09:06:34 UTC
Created attachment 1589811 [details]
proposed patch

While trying to build udisks2 flatpak from rpm I faced an issue with hardcoded sysconfdir in the %configure macro call in the .spec file. The flatpak build has it in /app/etc/ instead, thus it breaks the build there.

There can be done two approaches:
a) change the --sysconfdir=/etc to --sysconfdir=%{_sysconfdir}
b) do not declare --sysconfdir at all, because it's already provided, with correct value, in the %configure macro.

Comment 1 Vojtech Trefny 2019-07-12 09:13:46 UTC
upstream PR: https://github.com/storaged-project/udisks/pull/678

Thank you for the patch.

Comment 2 Tomáš Bžatek 2019-07-12 10:28:46 UTC
FYI, I'm going to release udisks-2.8.4 sometime next week so I'll update the Fedora packages accordingly. No need to build extra package just for this tiny change.

Comment 3 Milan Crha 2019-07-12 10:49:11 UTC
> No need to build extra package just for this tiny change.

Definitely, no hurry at all. I found it only accidentally.

Comment 4 Fedora Update System 2019-07-23 14:15:01 UTC
FEDORA-2019-65574a0e7a has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-65574a0e7a

Comment 5 Fedora Update System 2019-07-24 01:44:36 UTC
udisks2-2.8.4-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-65574a0e7a

Comment 6 Fedora Update System 2019-08-08 00:55:10 UTC
udisks2-2.8.4-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.