Created attachment 1589833 [details] Patch for SUSE kmp naming convetions. Tested on CentOS 7 and SUSE 15 SP1 Description of problem: Using kmodtool for packaging kernel modules works great on Fedora/RHEL style platforms using the kmod naming prefix/postfix convention. Repackaging the same software for SUSE breaks the convention of using kmp for the postfix. Version-Release number of selected component (if applicable): How reproducible: Building ZFS for SUSE builds kmod-zfs where zfs-kmp is desired. Steps to Reproduce: 1. 2. 3. Actual results: Expected results: SUSE packages will be named zfs-kmp on SUSE and kmod-zfs on Fedora. Additional info: Patch attached. (Was unable to git clone / push via pagure ssh).
Thx for your contribution Shaun. It looks good at the first sight. I wonder if that's enough to have "kmod" support in suse ? Any others patch pending ? Is there any location where such zfs modules are maintained ? For information, there is a plan to progressively migrate kmodtool to use RPM macros instead, a start is located in this branch for secure boot support (still WIP). https://src.fedoraproject.org/fork/nvieville/rpms/kmodtool/commits/enhancements_and_secure_boot
I have this currently proposed for zfsonlinux: https://github.com/stancheff/zfs/tree/kmp-v4 And this is the SUSE/kmp changes for kmodtool https://github.com/zfsonlinux/zfs/commit/23481a448611a3ffb2dd90e23f673104359a5779 I've been trying to get this onto a fork in src.fedoraproject.org but I'm not very familiar with pagure and fedpkg.
Okay, I wish it could be possible to drop the -devel part that is still used, I don't get having a kmod-foo-devel really worth it, specially as solaris layer seems to be bundled within the zfs nowadays.
In zfs case it is use by lustre to build a zfs-osd (object storage device) target layer so the -devel package(s) are used. If not for kmods built on kmods I would agree. I suspect there are other packages with similar use cases, MOFED comes to mind.
This is a pretty rare use-case (or we would had more pressure to maintain that). Components having differents kernel modules are provided together to avoid such situation (VirtualBox guest/hosts - Nvidia modeset/uvm/drm ) To me having a kmod-foo-devel always was a big hammer. And I still don't get the reason behind such ? (If you want to fill a separate issue to investigate that, feel free). With that said, what is really used by the lustre component ? And does the "zfs/solaris layer header" really change that often ? Does it change on depending on the kernel options ? kernel version of zfs/solaris struct version/change ? do you want to have a repos with different kmod-zfs-devel for various kernel ?) I think it might more make sense to "bundle" or eventually to drop a -devel from the "userspace" sub-package instead of kmod-zfs (even if the header is meant for kernel space). This might looks simple using local build or even buildsys that do not check carefully "gate" dependencies (like koji does for good reasons), but is incredibly complex from an infra perspective (for no gain).
So I've clone the bug to have a separate ticket for the -devel issue as 1729911
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to '31'.
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle. Changing version to 31.
This message is a reminder that Fedora 31 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora 31 on 2020-11-24. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '31'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 31 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
This bug appears to have been reported against 'rawhide' during the Fedora 34 development cycle. Changing version to 34.
It seems like another attempt to solve this issue was merged into rawhide. But this lead to issue. Can we revisit this issue and try to submit a new MR using https://src.fedoraproject.org/rpms/kmodtool Thanks in advance.
This message is a reminder that Fedora Linux 34 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora Linux 34 on 2022-06-07. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a 'version' of '34'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, change the 'version' to a later Fedora Linux version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora Linux 34 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora Linux, you are encouraged to change the 'version' to a later version prior to this bug being closed.
*** Bug 2012209 has been marked as a duplicate of this bug. ***
yet not fixed
This bug appears to have been reported against 'rawhide' during the Fedora Linux 37 development cycle. Changing version to 37.
(In reply to Nicolas Chauvet (kwizart) from comment #11) > It seems like another attempt to solve this issue was merged into rawhide. > But this lead to issue. > > Can we revisit this issue and try to submit a new MR using > https://src.fedoraproject.org/rpms/kmodtool I'm afraid nothing has changed, for this issue, while this would have sounded and easy refactoring, actually isn't. What is the downside of using kmod-foo in SuSe (and or everywhere else) ? I'm not strongly opposed to this change, (at least splitting the re-factoring and the kmd/suse part seems doable easily, so the former get merged). I'm open to merge via pagure, but let's close this issue if it's not going to be fixed.