Spec URL: https://copr-be.cloud.fedoraproject.org/results/atim/corectrl/fedora-30-x86_64/00972260-corectrl/corectrl.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/atim/corectrl/fedora-30-x86_64/00972260-corectrl/corectrl-1.0.3-5.fc30.src.rpm Description: CoreCtrl is a Free and Open Source GNU/Linux application that allows you to control with ease your computer hardware using application profiles. It aims to be flexible, comfortable and accessible to regular users. Fedora Account System Username: atim Working COPR: https://copr.fedorainfracloud.org/coprs/atim/corectrl
I will review this package.
Spec URL: https://copr-be.cloud.fedoraproject.org/results/atim/corectrl/fedora-30-x86_64/00972266-corectrl/corectrl.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/atim/corectrl/fedora-30-x86_64/00972266-corectrl/corectrl-1.0.3-6.fc30.src.rpm
Spec URL: https://copr-be.cloud.fedoraproject.org/results/atim/corectrl/fedora-30-x86_64/00972707-corectrl/corectrl.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/atim/corectrl/fedora-30-x86_64/00972707-corectrl/corectrl-1.0.3-10.fc30.src.rpm
1. As you use cmake, it would be better to replace all pkgconfig to cmake() where possible: BuildRequires: cmake(Qt5Svg) BuildRequires: cmake(Qt5DBus) BuildRequires: cmake(Qt5Core) BuildRequires: cmake(Qt5Widgets) BuildRequires: cmake(Qt5Network) BuildRequires: cmake(Qt5Multimedia) BuildRequires: cmake(Qt5Concurrent) BuildRequires: cmake(Qt5LinguistTools) > export AR=%{_bindir}/gcc-ar > export RANLIB=%{_bindir}/gcc-ranlib > export NM=%{_bindir}/gcc-nm 2. Now you don't need to export this manually. Use cmake options instead: %cmake \ -DCMAKE_AR=%{_bindir}/gcc-ar \ -DCMAKE_RANLIB=%{_bindir}/gcc-ranlib \ -DCMAKE_NM=%{_bindir}/gcc-nm \ .. > -DCMAKE_INSTALL_PREFIX=%{_prefix} 3. Already included to %cmake macro. 4. Please add AppData manifest and send it to upstream. > %files devel > %{_libdir}/libcorectrl.so Development package without any useful headers. Just remove %{_libdir}/libcorectrl.so symbolic link. > global optflags %{optflags} -flto > %global build_ldflags %{build_ldflags} -flto Cmake has built-in IPO feature. You can use it instead of changing build flags.
Spec URL: https://copr-be.cloud.fedoraproject.org/results/atim/corectrl/fedora-30-x86_64/00972917-corectrl/corectrl.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/atim/corectrl/fedora-30-x86_64/00972917-corectrl/corectrl-1.0.3-13.fc30.src.rpm
> pkgconfig(qca2-qt5) 1. BuildRequires: cmake(Qca) 2. QCA need to be added to depencencies explicitly: Requires: qca-qt5-ossl%{?_isa} 3. AppData manifest file is still missing.
Sorry, BuildRequires: cmake(Qca-qt5) is correct.
Spec URL: https://copr-be.cloud.fedoraproject.org/results/atim/corectrl/fedora-30-x86_64/00973261-corectrl/corectrl.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/atim/corectrl/fedora-30-x86_64/00973261-corectrl/corectrl-1.0.3-15.fc30.src.rpm Now working on AppData manifest file...
Spec URL: https://copr-be.cloud.fedoraproject.org/results/atim/corectrl/fedora-30-x86_64/00973305-corectrl/corectrl.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/atim/corectrl/fedora-30-x86_64/00973305-corectrl/corectrl-1.0.4-3.fc30.src.rpm
Spec URL: https://copr-be.cloud.fedoraproject.org/results/atim/corectrl/fedora-30-x86_64/00973450-corectrl/corectrl.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/atim/corectrl/fedora-30-x86_64/00973450-corectrl/corectrl-1.0.4-4.fc30.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GNU General Public License", "*No copyright* Public domain", "GPL (v3 or later)", "Expat License", "BSD 2-clause "Simplified" License", "*No copyright* BSL", "BSL (v1.0)". [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: corectrl-1.0.4-4.fc31.x86_64.rpm corectrl-debuginfo-1.0.4-4.fc31.x86_64.rpm corectrl-debugsource-1.0.4-4.fc31.x86_64.rpm corectrl-1.0.4-4.fc31.src.rpm corectrl.x86_64: W: spelling-error %description -l en_US xdg -> bldg corectrl.x86_64: W: spelling-error %description -l en_US md -> MD, Md, ms corectrl.x86_64: W: obsolete-not-provided corectrl-devel corectrl.x86_64: W: no-manual-page-for-binary corectrl corectrl.src: W: spelling-error %description -l en_US xdg -> bldg corectrl.src: W: spelling-error %description -l en_US usr -> use, us, user corectrl.src: W: spelling-error %description -l en_US md -> MD, Md, ms corectrl.src:64: W: unversioned-explicit-provides bundled(units) corectrl.src:66: W: unversioned-explicit-obsoletes %{name}-devel 4 packages and 0 specfiles checked; 0 errors, 9 warnings. Rpmlint (debuginfo) ------------------- Checking: corectrl-debuginfo-1.0.4-4.fc31.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- corectrl-debuginfo.x86_64: W: invalid-url URL: https://gitlab.com/corectrl/corectrl <urlopen error [Errno -2] Name or service not known> corectrl-debugsource.x86_64: W: invalid-url URL: https://gitlab.com/corectrl/corectrl <urlopen error [Errno -2] Name or service not known> corectrl.x86_64: W: spelling-error %description -l en_US xdg -> bldg corectrl.x86_64: W: spelling-error %description -l en_US md -> MD, Md, ms corectrl.x86_64: W: invalid-url URL: https://gitlab.com/corectrl/corectrl <urlopen error [Errno -2] Name or service not known> corectrl.x86_64: W: obsolete-not-provided corectrl-devel corectrl.x86_64: W: no-manual-page-for-binary corectrl 3 packages and 0 specfiles checked; 0 errors, 7 warnings. Source checksums ---------------- https://gitlab.com/corectrl/corectrl/-/archive/v1.0.4/corectrl-1.0.4.tar.gz : CHECKSUM(SHA256) this package : fe03624335c7794d8f377a653b4e882dc90bb9717fe180b8b2a29df86fbd15b1 CHECKSUM(SHA256) upstream package : fe03624335c7794d8f377a653b4e882dc90bb9717fe180b8b2a29df86fbd15b1 Requires -------- corectrl (rpmlib, GLIBC filtered): dbus-common hicolor-icon-theme libKF5Archive.so.5()(64bit) libKF5AuthCore.so.5()(64bit) libKF5CoreAddons.so.5()(64bit) libQt5Charts.so.5()(64bit) libQt5Charts.so.5(Qt_5)(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.12)(64bit) libQt5DBus.so.5()(64bit) libQt5DBus.so.5(Qt_5)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5Qml.so.5()(64bit) libQt5Qml.so.5(Qt_5)(64bit) libQt5Quick.so.5()(64bit) libQt5Quick.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libbotan-2.so.11()(64bit) libc.so.6()(64bit) libcorectrl.so.0()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) polkit(x86-64) qca-qt5-ossl(x86-64) qt5-qtquickcontrols2(x86-64) rtld(GNU_HASH) corectrl-debuginfo (rpmlib, GLIBC filtered): corectrl-debugsource (rpmlib, GLIBC filtered): Provides -------- corectrl: application() application(CoreCtrl.desktop) bundled(easyloggingpp) bundled(fmt) bundled(pugixml) bundled(units) corectrl corectrl(x86-64) libcorectrl.so.0()(64bit) metainfo() metainfo(com.gitlab.corectrl.corectrl.appdata.xml) corectrl-debuginfo: corectrl-debuginfo corectrl-debuginfo(x86-64) debuginfo(build-id) corectrl-debugsource: corectrl-debugsource corectrl-debugsource(x86-64) Generated by fedora-review 0.7.2 (65d36bb) last change: 2019-04-09 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1730111 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: Perl, fonts, Ocaml, PHP, SugarActivity, R, Python, Haskell, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
There is nothing I can complain about now. Package approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/corectrl
FEDORA-2019-4ce6d396ff has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-4ce6d396ff
corectrl-1.0.4-5.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-4ce6d396ff
corectrl-1.0.4-5.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.