Bug 1731081
| Summary: | Label escaping bug for special characters breaks ipa dnszone-show | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | Christian Heimes <cheimes> |
| Component: | python-dns | Assignee: | Lumír Balhar <lbalhar> |
| Status: | CLOSED ERRATA | QA Contact: | Jan Houska <jhouska> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 8.2 | CC: | cstratak, jhouska, lbalhar, pviktori, torsava |
| Target Milestone: | rc | Keywords: | Reproducer, TestCaseNotNeeded |
| Target Release: | 8.2 | Flags: | pm-rhel:
mirror+
|
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | No Doc Update | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-04-28 16:44:32 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1640091 | ||
|
Description
Christian Heimes
2019-07-18 09:51:59 UTC
The fix has been in upstream master for a while. Upstream has retired 1.x release series in favor of 2.0 with Python 3-only support. It may be necessary to backport the fix to 1.5 manually and maintain a patch. I am going to take a look. We have the reproducer available so it should be easy to test the fix and I am going to backport. I've managed to backport the upstream patch to version 1.15 (RHEL8). Scratch build: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=23218020 Commit (my fork, rhel-8.1.é branch): https://src.osci.redhat.com/fork/lbalhar/rpms/python-dns/commits/rhel-8.1.0 Verification Old version: # rpm -qi python3-dns Name : python3-dns Version : 1.15.0 Release : 8.el8 # python3 Python 3.6.8 (default, Aug 6 2019, 19:43:07) [GCC 8.3.1 20190507 (Red Hat 8.3.1-4)] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import dns.name >>> name = dns.name.from_text("admin\\.1.example.com") >>> name <DNS name admin\.1.example.com.> >>> name.to_text() 'admin\\.1.example.com.' >>> name.to_unicode() 'admin.1.example.com.' New version: # rpm -qi python3-dns Name : python3-dns Version : 1.15.0 Release : 9.el8 # python3 Python 3.6.8 (default, Aug 6 2019, 19:43:07) [GCC 8.3.1 20190507 (Red Hat 8.3.1-4)] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import dns.name >>> name = dns.name.from_text("admin\\.1.example.com") >>> name <DNS name admin\.1.example.com.> >>> name.to_text() 'admin\\.1.example.com.' >>> name.to_unicode() 'admin\\.1.example.com.' Everything is ready and tested on RHEL 8.1 so the fix has to wait until there will be a branch for RHEL 8.2. But it's already ready for a review. The backported patch also contains one new test for to_unicode() method and a lot of existing tests are already there so I think that no new tests are needed from QA. Pull request is ready for review here: https://src.osci.redhat.com/rpms/python-dns/pull-request/2 The test is also backported in `tests/test_name.py` function `testToText12`. PR merged. Build: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=24188082 Before I'll be able to add the build to the errata, I need to enable gating. Gating configuration PR: https://src.osci.redhat.com/rpms/python-dns/pull-request/3 Beaker test configuration change and prove that it works well for this bug: https://src.osci.redhat.com/tests/python-dns/pull-request/1 Could you please help me to enable gating for this component? Lumir, please also provide the command to start only the relevant upstream test that fixes the issue, so that QE can make a Regression test case for it. Both PRs from comment#8 merged, release bumped. New build (for gating): https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=24238288 Command to run the backported test: python3 -m unittest -v tests.test_name.NameTestCase.testToText12 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:1789 |