Document URL: https://access.redhat.com/documentation/en-us/openshift_container_platform/3.11/html-single/configuring_clusters/index#aggregate-logging-ansible-variables Section Number and Name: "36.3. Specifying Logging Ansible Variables" Describe the issue: Section 36.3, in the "Configuring clusters" document, is missing a section for supported time units. An example is `openshift_logging_es_recover_after_time`, which admits either seconds (s) or minutes (m) as time unit value. Suggestions for improvement: add a note of supported time units in the `Logging Ansible Variables` section, like the one seen in [1]. `Supported time units are microseconds (us), milliseconds (ms), seconds (s), minutes (m), hours (h), or days (d).` --- [1] https://docs.openshift.com/container-platform/4.1/networking/routes/route-configuration.html#nw-configuring-route-timeouts_route-configuration
Hi Robert, Looking through that table, I see the following items referring to a specific time: * openshift_logging_es_recover_after_time - You mentioned this one already, and said allowed values are seconds (s) or minutes (m). * openshift_logging_es_ops_recover_after_time - This one is described as "Equivalent to openshift_logging_es_recovery_after_time for Ops cluster when openshift_logging_use_ops is set to true." Does this mean this item should also have allowed values of seconds (s) or minutes (m) stated? Let me know about that, and also let me know if I missed anything that needs to be fixed.
Hi Jeana. Yes, I'd say both openshift_logging_es_recover_after_time & openshift_logging_es_ops_recover_after_time should be updated to add the supported time units. Also, the "Equivalent to openshift_logging_es_recovery_after_time [...]" snippet seems to have a typo (recovery != recover) that we should likely also update. Thank you.
Hi Robert - thanks for verifying and excellent catch on recovery != recover :) Will fix that too.
Made changes as described in Comment 2 above. This can be reviewed here: https://github.com/openshift/openshift-docs/pull/20885/files Moving this bug to ON_QA for verification.
Found a bug https://bugzilla.redhat.com/show_bug.cgi?id=1822093.
Waiting on new bug to be fixed per Comment 5 Thanks, Anping!
Per Vikram's guidance on the PR, will remove reference to openshift_logging_es_ops_recover_after_time in response to https://bugzilla.redhat.com/show_bug.cgi?id=1822093.
Ready for a re-check.
Anping Li left "LGTM" on PR, marking this verified
PR merged, pending online update
Fix online: https://docs.openshift.com/container-platform/3.11/install_config/aggregate_logging.html#aggregate-logging-ansible-variables https://access.redhat.com/documentation/en-us/openshift_container_platform/3.11/html-single/configuring_clusters/index#aggregate-logging-ansible-variables