Bug 1731914 - RDO Package Review: collectd-sensubility
Summary: RDO Package Review: collectd-sensubility
Keywords:
Status: POST
Alias: None
Product: RDO
Classification: Community
Component: Package Review
Version: trunk
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: trunk
Assignee: Matthias Runge
QA Contact: hguemar
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-07-22 11:33 UTC by Martin Magr
Modified: 2019-07-22 12:41 UTC (History)
0 users

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
mrunge: rdo-review+


Attachments (Terms of Use)
spec file (2.15 KB, text/plain)
2019-07-22 11:33 UTC, Martin Magr
no flags Details
srpm (308.38 KB, application/x-rpm)
2019-07-22 11:33 UTC, Martin Magr
no flags Details
spec mk.2 (2.17 KB, text/plain)
2019-07-22 12:28 UTC, Martin Magr
no flags Details

Description Martin Magr 2019-07-22 11:33:10 UTC
Created attachment 1592571 [details]
spec file

Please review the package. Spec file and SRPM is included in the BZ.

Comment 1 Martin Magr 2019-07-22 11:33:40 UTC
Created attachment 1592572 [details]
srpm

Comment 2 Matthias Runge 2019-07-22 12:09:03 UTC
Thank you, this looks good, but please add the license file to the package and mark it as license
%license LICENSE

Once that is done, we are good to go.

Comment 3 Matthias Runge 2019-07-22 12:15:50 UTC
To add here:
juju-errors and
rs/zerolog
are the only missing deps, everything else is already included in Fedora.

Comment 4 Martin Magr 2019-07-22 12:28:45 UTC
Created attachment 1592581 [details]
spec mk.2


Note You need to log in before you can comment on or make changes to this bug.