Spec Name or Url: http://mitgcm.org/eh3/fedora_misc/osiv.spec SRPM Name or Url: http://mitgcm.org/eh3/fedora_misc/osiv-0.1.1-1.src.rpm Description: OSIV is an Open Source Image Velocimetry package. Its a command-line tool for determining fluid velocities from pairs of images.
Good: - rpmlint checks return: ok - package meets naming guidelines - package meets packaging guidelines - license GPL, ok. - source matches upstream - package compiles on fc4/devel (x86) - no missing BR - no unnecessary BR - permissions ok questions/info needed: - Should the java/matlab support files be packaged? nits: - Might add AUTHORS file to doc? I can't seem to yet assign this bug to myself to approve, will try and track down why. :)
Thanks for the review! > - Should the java/matlab support files be packaged? Unfortunately, the three MatLAB files are all MEX-files and, AFAIK, cannot be used with Octave: http://www.octave.org/octave-lists/archive/help-octave.1996/msg00167.html So, because of their build dependencies on non-Fedora packages, it seems that they can't be included in Fedora--at least not in non-source form. The java files I'll try to include in a future version. They have no associatded Makefiles so I'm not certain how to package them -- any suggestions? If its acceptable, I'd like to leave the java bits out for the time being since they are not a critical part of the OSIV command-line tools (works just fine without them). > - Might add AUTHORS file to doc? Sure, done! http://mitgcm.org/eh3/fedora_misc/osiv-0.1.1-2.src.rpm http://mitgcm.org/eh3/fedora_misc/osiv.spec
ok on the MatLab files. :( For the java files, not sure how best to package them. They would likely be copied into a web server area to be used? But thats all likely to be very site specific. Perhaps adding them into a share dir so they can be copied where they are needed? As you say though that can be done down the road. Everything else looks good to me... APPROVED.
Built on FC-4 and devel...