Red Hat Bugzilla – Bug 173216
Review Request: OSIV: Open Source Image Velocimetry
Last modified: 2007-11-30 17:11:17 EST
Spec Name or Url: http://mitgcm.org/eh3/fedora_misc/osiv.spec
SRPM Name or Url: http://mitgcm.org/eh3/fedora_misc/osiv-0.1.1-1.src.rpm
OSIV is an Open Source Image Velocimetry package. Its a command-line tool
for determining fluid velocities from pairs of images.
- rpmlint checks return: ok
- package meets naming guidelines
- package meets packaging guidelines
- license GPL, ok.
- source matches upstream
- package compiles on fc4/devel (x86)
- no missing BR
- no unnecessary BR
- permissions ok
- Should the java/matlab support files be packaged?
- Might add AUTHORS file to doc?
I can't seem to yet assign this bug to myself to approve, will try and track
down why. :)
Thanks for the review!
> - Should the java/matlab support files be packaged?
Unfortunately, the three MatLAB files are all MEX-files and, AFAIK, cannot
be used with Octave:
So, because of their build dependencies on non-Fedora packages, it seems
that they can't be included in Fedora--at least not in non-source form.
The java files I'll try to include in a future version. They have no
associatded Makefiles so I'm not certain how to package them -- any
If its acceptable, I'd like to leave the java bits out for the time
being since they are not a critical part of the OSIV command-line tools
(works just fine without them).
> - Might add AUTHORS file to doc?
ok on the MatLab files. :(
For the java files, not sure how best to package them. They would likely be
copied into a web server area to be used? But thats all likely to be very site
specific. Perhaps adding them into a share dir so they can be copied where they
are needed? As you say though that can be done down the road.
Everything else looks good to me...
Built on FC-4 and devel...