Bug 1732311 - Review Request: perl-Test-NiceDump - Get a nice and human readable dump of objects
Summary: Review Request: perl-Test-NiceDump - Get a nice and human readable dump of ob...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1731013
TreeView+ depends on / blocked
 
Reported: 2019-07-23 07:12 UTC by Jitka Plesnikova
Modified: 2019-07-24 13:10 UTC (History)
2 users (show)

Fixed In Version: perl-Test-NiceDump-1.0.1-1.fc31
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-07-24 13:10:34 UTC
ppisar: fedora-review+


Attachments (Terms of Use)

Description Jitka Plesnikova 2019-07-23 07:12:17 UTC
Spec URL: https://jplesnik.fedorapeople.org/perl-Test-NiceDump/perl-Test-NiceDump.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-Test-NiceDump/perl-Test-NiceDump-1.0.1-1.fc31.src.rpm

Description:
This module uses Data::Dump::Filtered and a set of sensible filters to dump
test data in a more readable way.

Fedora Account System Username: jplesnik@redhat.com

Comment 1 Petr Pisar 2019-07-23 12:32:08 UTC
Url and Source0 addresses are Ok.
Source0 archive (SHA-256: 122877276af68032eb6d7f899ff4ec91c9e21380198fba73839b2e04ecd4ba63) is original. Ok.
Summary is Ok.
Description verified from lib/Test/NiceDump.pm. Ok.
License verified from lib/Test/NiceDump.pm, Makefile.PL, README.md, and LICENSE. Ok.
No XS code, noarch BuildArch is Ok.
BuildRequires are Ok.

TODO: Unset AUTHOR_TESTING environment variable in %check section to make the build reproducible (t/author-pod-coverage.t:4).

All tests pass. Ok.

$ rpmlint perl-Test-NiceDump.spec ../SRPMS/perl-Test-NiceDump-1.0.1-1.fc31.src.rpm ../RPMS/noarch/perl-Test-NiceDump-1.0.1-1.fc31.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Test-NiceDump-1.0.1-1.fc31.noarch.rpm 
drwxr-xr-x    2 root     root                        0 Jul 23 14:26 /usr/share/doc/perl-Test-NiceDump
-rw-r--r--    1 root     root                      298 Jul 17 16:53 /usr/share/doc/perl-Test-NiceDump/Changes
-rw-r--r--    1 root     root                      955 Jul 17 16:53 /usr/share/doc/perl-Test-NiceDump/README.md
drwxr-xr-x    2 root     root                        0 Jul 23 14:26 /usr/share/licenses/perl-Test-NiceDump
-rw-r--r--    1 root     root                    18424 Jul 17 16:53 /usr/share/licenses/perl-Test-NiceDump/LICENSE
-rw-r--r--    1 root     root                     2641 Jul 23 14:26 /usr/share/man/man3/Test::NiceDump.3pm.gz
drwxr-xr-x    2 root     root                        0 Jul 23 14:26 /usr/share/perl5/vendor_perl/Test
-rw-r--r--    1 root     root                     6033 Jul 17 16:53 /usr/share/perl5/vendor_perl/Test/NiceDump.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Test-NiceDump-1.0.1-1.fc31.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.30.0)
      1 perl(Data::Dump)
      1 perl(Data::Dump::Filtered)
      1 perl(Exporter)
      1 perl(overload)
      1 perl(Safe::Isa) >= 1.000010
      1 perl(strict)
      1 perl(Test::Builder)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Test-NiceDump-1.0.1-1.fc31.noarch.rpm | sort -f | uniq -c
      1 perl(Test::NiceDump) = 1.0.1
      1 perl-Test-NiceDump = 1.0.1-1.fc31
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Test-NiceDump-1.0.1-1.fc31.noarch.rpm 
Binary dependencies are resolvable. Ok.

The package builds in F31 (https://koji.fedoraproject.org/koji/taskinfo?taskID=36444787). Ok.

The package is in line with Fedora and Perl packaging guide lines.

Please consider fixing the 'TODO' item before building this package.
Resolution: Package APPROVED.

Comment 2 Gwyn Ciesla 2019-07-24 12:48:53 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Test-NiceDump

Comment 3 Jitka Plesnikova 2019-07-24 13:10:34 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.