Hide Forgot
Description of problem: I installed the following templates with the script overcloud_deploy.sh https://gitlab.cee.redhat.com/mnietoji/deployment_templates/tree/master/balance-tcp/ospd-13-vxlan-dpdk-sriov-ctlplane-dataplane-bonding-hybrid_panther08_balance-tcp_lacp_nic_partitioning then I modify one template replacing DpdkBondInterfaceOvsOptions: "bond_mode=balance-tcp lacp=active other_config:lacp-time=fast other-config:lacp-fallback-ab=true" by DpdkBondInterfaceOvsOptions: "bond_mode=balance-slb" and executed again overcloud_deploy.sh checking the parameters, it is properly replaced (undercloud) [stack@undercloud-0 ~]$ openstack stack environment show overcloud | grep DpdkBondInterfaceOvsOptions DpdkBondInterfaceOvsOptions: bond_mode=balance-slb But if I go to the compute node and check if configuration has changed, I do not see any change [root@computeovsdpdksriov-0 network-scripts]# cat /etc/sysconfig/network-scripts/ifcfg-dpdkbond1 | grep OVS_OPTIONS OVS_OPTIONS="bond_mode=balance-tcp lacp=active other_config:lacp-time=fast other-config:lacp-fallback-ab=true" An the running configuration is not ok either [root@computeovsdpdksriov-0 network-scripts]# ovs-appctl bond/show dpdkbond1 ---- dpdkbond1 ---- bond_mode: balance-tcp bond may use recirculation: yes, Recirc-ID : 1 bond-hash-basis: 0 updelay: 0 ms downdelay: 0 ms next rebalance: 5314 ms lacp_status: configured lacp_fallback_ab: true active slave mac: 92:85:c8:11:8e:d1(dpdk3) slave dpdk2: enabled may_enable: true slave dpdk3: enabled active slave may_enable: true Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
Updating through this command is not working either. It think it must be related openstack stack update --existing --parameter DpdkBondInterfaceOvsOptions="bond_mode=active-backup" overcloud
I do not believe the networking configuration is rerun on updates. In order to have the network configuration applied on updates, you'd need to specify NetworkDeploymentActions: ['CREATE','UPDATE'], however this could possibly introduce a network interruption if a change will cause interfaces to be bounced. I'd have to defer to the networking team on the impact of switching the bond mode on a live system.
Thanks for the comment. I tried adding NetworkDeploymentActions: ['CREATE','UPDATE'] to the templates and it updated the config properly. About the openstack update, should this command update the network config? I tried it and it didnt work openstack stack update --existing --parameter DpdkBondInterfaceOvsOptions="bond_mode=active-backup" --parameter NetworkDeploymentActions="['CREATE','UPDATE']" overcloud
I've never used the --parameter option on stack update. I believe the recommended way is to update the templates and rerun the deployment command. Going forward the stack will have less and less to do with the actual deployment so it's not a best practice to use the openstack stack commands to update things.
I agree with Bernard that Comment 3 ("I tried adding NetworkDeploymentActions: ['CREATE','UPDATE'] to the templates and it updated the config properly") indicates that the recommendation to set UPDATE has worked. This should be set in the template, as was done, not on the the command line. I recommend closing this.