NOTE: this is a split from the main numpy SRPM because the latest upstream discontinues Python2 support. SPEC: https://fedorapeople.org/~limb/review/python2-numpy/python2-numpy.spec SRPM: https://fedorapeople.org/~limb/review/python2-numpy/python2-numpy-1.16.4-4.fc30.src.rpm
Running automated checks. In the meantime, here are the things that I find weird: Requires: python2-nose Why is this a runtime dependency? Provides: numpy = %{epoch}:%{version}-%{release} Provides: numpy%{?_isa} = %{epoch}:%{version}-%{release} Provides: f2py = %{epoch}:%{version}-%{release} Provides: numpy-f2py = %{epoch}:%{version}-%{release} I believe those should now be in the Python 3 package: https://fedoraproject.org/wiki/Changes/Python_means_Python3 Note that any Requires, Provides, Obsoletes bellow the %descripton are evaluated as part of that description and will not end up in the package metadata. %package -n python2-numpy-f2py -> %package f2py %package -n python2-numpy-doc -> %package doc %files -n python2-numpy -> %files %files -n python2-numpy-f2py -> %files f2py %files -n python2-numpy-doc -> %files doc %if 0%{?fedora} >= 21 || 0%{?rhel} > 7 -> %if 0%{?fedora} || 0%{?rhel} > 7 %if %{_arch} != s390x && %{_arch} != ppc64le -> %ifnarch s390x ppc64le %{python2_sitearch}/%{modname}-*.egg-info Add trailing slash if a directory? %files -n python2-numpy-f2py %doc docs/f2py/*.html ... %files -n python2-numpy-doc %doc docs/* Is docs/f2py/*.html in both?
I also suggest to update the summary: > Summary: A fast multidimensional array facility for Python Summary: A fast multidimensional array facility for Python 2
Also those should be in Python 3: %{_bindir}/f2py %{_bindir}/f2py.numpy
I've fixed most of this but will hold off posting a new SRPM until your tests finish. I think the numpy Provides should follow python2-numpy, as the python3- naming is compliant and that isn't. It also minimizes breakage for users if dependent packages have bad Requires on numpy. The duplicated docs are to prevent broken hyperlinks.
Post the new one please, the checks are fast.
> I think the numpy Provides should follow python2-numpy... BTW I don't agree but won't block this review on that.
Done. SPEC: https://fedorapeople.org/~limb/review/python2-numpy/python2-numpy.spec SRPM: https://fedorapeople.org/~limb/review/python2-numpy/python2-numpy-1.16.4-4.fc30.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: python2-numpy. /usr/lib64/python2.7/site-packages/numpy/core/lib/libnpymath.a See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#packaging-static-libraries - Please recheck the License. - https://docs.scipy.org/doc/numpy/numpy-html-1.16.1.zip is 404 - f2py should require numpy with %_isa ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [ ]: Package contains no static executables. There is /usr/lib64/python2.7/site-packages/numpy/core/lib/libnpymath.a [-]: Development (unversioned) .so files in -devel subpackage, if present. Not relevant. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-clause "New" or "Revised" License", "BSD 2-clause "Simplified" License", "*No copyright* BSD (unspecified)", "Expat License", "BSD (unspecified)", "Expat License BSD 3-clause "New" or "Revised" License", "zlib/libpng license", "Apache License (v2.0)", "Python Software Foundation License version 2". 1095 files have unknown license. Detailed output of licensecheck: *No copyright* BSD (unspecified) -------------------------------- numpy-1.16.4/doc/sphinxext/setup.py Apache License (v2.0) --------------------- numpy-1.16.4/doc/scipy-sphinx-theme/_theme/scipy/static/css/spc-bootstrap.css numpy-1.16.4/doc/scipy-sphinx-theme/_theme/scipy/static/less/bootstrap/bootstrap.less numpy-1.16.4/doc/scipy-sphinx-theme/_theme/scipy/static/less/bootstrap/responsive.less BSD (unspecified) ----------------- numpy-1.16.4/doc/scipy-sphinx-theme/_theme/scipy/layout.html numpy-1.16.4/doc/scipy-sphinx-theme/_theme/scipy/static/scipy.css_t numpy-1.16.4/doc/source/_templates/defindex.html numpy-1.16.4/doc/source/_templates/searchbox.html numpy-1.16.4/numpy/random/mtrand/Python.pxi BSD 2-clause "Simplified" License --------------------------------- numpy-1.16.4/doc/sphinxext/LICENSE.txt numpy-1.16.4/numpy/core/src/npymath/npy_math_complex.c.src numpy-1.16.4/numpy/testing/_private/parameterized.py BSD 3-clause "New" or "Revised" License --------------------------------------- numpy-1.16.4/LICENSE.txt numpy-1.16.4/doc/scipy-sphinx-theme/LICENSE.txt numpy-1.16.4/doc/source/license.rst numpy-1.16.4/numpy/linalg/lapack_lite/LICENSE.txt numpy-1.16.4/numpy/ma/LICENSE numpy-1.16.4/numpy/random/mtrand/initarray.c numpy-1.16.4/tools/swig/numpy.i Expat License ------------- numpy-1.16.4/numpy/random/mtrand/distributions.c numpy-1.16.4/numpy/random/mtrand/distributions.h numpy-1.16.4/numpy/random/mtrand/mtrand.pyx numpy-1.16.4/numpy/random/mtrand/randomkit.h numpy-1.16.4/tools/npy_tempita/license.txt Expat License BSD 3-clause "New" or "Revised" License ----------------------------------------------------- numpy-1.16.4/numpy/random/mtrand/randomkit.c Python Software Foundation License version 2 -------------------------------------------- numpy-1.16.4/doc/scipy-sphinx-theme/_theme/scipy/static/js/copybutton.js [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 276480 bytes in 9 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source1: https://docs.scipy.org/doc/numpy/numpy-html-1.16.1.zip See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-numpy-f2py [?]: Package functions as described. [-]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: SourceX tarball generation or download is documented. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-numpy-1.16.4-4.fc31.x86_64.rpm python2-numpy-f2py-1.16.4-4.fc31.x86_64.rpm python2-numpy-doc-1.16.4-4.fc31.noarch.rpm python2-numpy-debuginfo-1.16.4-4.fc31.x86_64.rpm python2-numpy-debugsource-1.16.4-4.fc31.x86_64.rpm python2-numpy-1.16.4-4.fc31.src.rpm python2-numpy.x86_64: W: spelling-error %description -l en_US numarray -> numeracy python2-numpy.x86_64: W: spelling-error %description -l en_US fourier -> Fourier, courier, furrier python2-numpy.x86_64: E: library-not-linked-against-libc /usr/lib64/python2.7/site-packages/numpy/core/_dummy.so python2-numpy.x86_64: E: library-not-linked-against-libc /usr/lib64/python2.7/site-packages/numpy/core/_operand_flag_tests.so python2-numpy.x86_64: E: zero-length /usr/lib64/python2.7/site-packages/numpy/core/_aliased_types.py python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/__multiarray_api.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/__ufunc_api.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/_neighborhood_iterator_imp.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/_numpyconfig.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/arrayobject.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/arrayscalars.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/halffloat.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/ndarrayobject.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/ndarraytypes.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/noprefix.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/npy_1_7_deprecated_api.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/npy_3kcompat.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/npy_common.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/npy_cpu.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/npy_endian.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/npy_interrupt.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/npy_math.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/npy_no_deprecated_api.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/npy_os.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/numpyconfig.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/old_defines.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/oldnumeric.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/ufuncobject.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/utils.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/lib/libnpymath.a python2-numpy.x86_64: E: wrong-script-interpreter /usr/lib64/python2.7/site-packages/numpy/distutils/conv_template.py /usr/bin/env python python2-numpy.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/distutils/conv_template.py 644 /usr/bin/env python python2-numpy.x86_64: E: wrong-script-interpreter /usr/lib64/python2.7/site-packages/numpy/distutils/cpuinfo.py /usr/bin/env python python2-numpy.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/distutils/cpuinfo.py 644 /usr/bin/env python python2-numpy.x86_64: E: wrong-script-interpreter /usr/lib64/python2.7/site-packages/numpy/distutils/from_template.py /usr/bin/env python python2-numpy.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/distutils/from_template.py 644 /usr/bin/env python python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/distutils/mingw/gfortran_vs2003_hack.c python2-numpy.x86_64: E: wrong-script-interpreter /usr/lib64/python2.7/site-packages/numpy/distutils/setup.py /usr/bin/env python python2-numpy.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/distutils/setup.py 644 /usr/bin/env python python2-numpy.x86_64: E: wrong-script-interpreter /usr/lib64/python2.7/site-packages/numpy/distutils/system_info.py /usr/bin/env python python2-numpy.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/distutils/system_info.py 644 /usr/bin/env python python2-numpy.x86_64: E: wrong-script-interpreter /usr/lib64/python2.7/site-packages/numpy/ma/bench.py /usr/bin/env python python2-numpy.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/ma/bench.py 644 /usr/bin/env python python2-numpy.x86_64: E: wrong-script-interpreter /usr/lib64/python2.7/site-packages/numpy/ma/setup.py /usr/bin/env python python2-numpy.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/ma/setup.py 644 /usr/bin/env python python2-numpy.x86_64: E: wrong-script-interpreter /usr/lib64/python2.7/site-packages/numpy/matrixlib/setup.py /usr/bin/env python python2-numpy.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/matrixlib/setup.py 644 /usr/bin/env python python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/random/randomkit.h python2-numpy.x86_64: E: wrong-script-interpreter /usr/lib64/python2.7/site-packages/numpy/setup.py /usr/bin/env python python2-numpy.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/setup.py 644 /usr/bin/env python python2-numpy.x86_64: E: wrong-script-interpreter /usr/lib64/python2.7/site-packages/numpy/testing/print_coercion_tables.py /usr/bin/env python python2-numpy.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/testing/print_coercion_tables.py 644 /usr/bin/env python python2-numpy.x86_64: E: wrong-script-interpreter /usr/lib64/python2.7/site-packages/numpy/testing/setup.py /usr/bin/env python python2-numpy.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/testing/setup.py 644 /usr/bin/env python python2-numpy-f2py.x86_64: E: devel-dependency python2-devel python2-numpy-f2py.x86_64: W: summary-not-capitalized C f2py for numpy python2-numpy-f2py.x86_64: E: wrong-script-interpreter /usr/lib64/python2.7/site-packages/numpy/f2py/__init__.py /usr/bin/env python python2-numpy-f2py.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/f2py/__init__.py 644 /usr/bin/env python python2-numpy-f2py.x86_64: E: wrong-script-interpreter /usr/lib64/python2.7/site-packages/numpy/f2py/auxfuncs.py /usr/bin/env python python2-numpy-f2py.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/f2py/auxfuncs.py 644 /usr/bin/env python python2-numpy-f2py.x86_64: E: wrong-script-interpreter /usr/lib64/python2.7/site-packages/numpy/f2py/capi_maps.py /usr/bin/env python python2-numpy-f2py.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/f2py/capi_maps.py 644 /usr/bin/env python python2-numpy-f2py.x86_64: E: wrong-script-interpreter /usr/lib64/python2.7/site-packages/numpy/f2py/cb_rules.py /usr/bin/env python python2-numpy-f2py.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/f2py/cb_rules.py 644 /usr/bin/env python python2-numpy-f2py.x86_64: E: wrong-script-interpreter /usr/lib64/python2.7/site-packages/numpy/f2py/cfuncs.py /usr/bin/env python python2-numpy-f2py.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/f2py/cfuncs.py 644 /usr/bin/env python python2-numpy-f2py.x86_64: E: wrong-script-interpreter /usr/lib64/python2.7/site-packages/numpy/f2py/common_rules.py /usr/bin/env python python2-numpy-f2py.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/f2py/common_rules.py 644 /usr/bin/env python python2-numpy-f2py.x86_64: E: wrong-script-interpreter /usr/lib64/python2.7/site-packages/numpy/f2py/crackfortran.py /usr/bin/env python python2-numpy-f2py.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/f2py/crackfortran.py 644 /usr/bin/env python python2-numpy-f2py.x86_64: E: wrong-script-interpreter /usr/lib64/python2.7/site-packages/numpy/f2py/diagnose.py /usr/bin/env python python2-numpy-f2py.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/f2py/diagnose.py 644 /usr/bin/env python python2-numpy-f2py.x86_64: E: wrong-script-interpreter /usr/lib64/python2.7/site-packages/numpy/f2py/f2py2e.py /usr/bin/env python python2-numpy-f2py.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/f2py/f2py2e.py 644 /usr/bin/env python python2-numpy-f2py.x86_64: E: wrong-script-interpreter /usr/lib64/python2.7/site-packages/numpy/f2py/f90mod_rules.py /usr/bin/env python python2-numpy-f2py.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/f2py/f90mod_rules.py 644 /usr/bin/env python python2-numpy-f2py.x86_64: E: wrong-script-interpreter /usr/lib64/python2.7/site-packages/numpy/f2py/func2subr.py /usr/bin/env python python2-numpy-f2py.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/f2py/func2subr.py 644 /usr/bin/env python python2-numpy-f2py.x86_64: E: wrong-script-interpreter /usr/lib64/python2.7/site-packages/numpy/f2py/rules.py /usr/bin/env python python2-numpy-f2py.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/f2py/rules.py 644 /usr/bin/env python python2-numpy-f2py.x86_64: E: wrong-script-interpreter /usr/lib64/python2.7/site-packages/numpy/f2py/setup.py /usr/bin/env python python2-numpy-f2py.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/f2py/setup.py 644 /usr/bin/env python python2-numpy-f2py.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/f2py/src/fortranobject.c python2-numpy-f2py.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/f2py/src/fortranobject.h python2-numpy-f2py.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/f2py/tests/src/array_from_pyobj/wrapmodule.c python2-numpy-f2py.x86_64: W: hidden-file-or-dir /usr/lib64/python2.7/site-packages/numpy/f2py/tests/src/assumed_shape/.f2py_f2cmap python2-numpy-f2py.x86_64: E: wrong-script-interpreter /usr/lib64/python2.7/site-packages/numpy/f2py/use_rules.py /usr/bin/env python python2-numpy-f2py.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/f2py/use_rules.py 644 /usr/bin/env python python2-numpy-f2py.x86_64: W: no-manual-page-for-binary f2py2 python2-numpy-f2py.x86_64: W: no-manual-page-for-binary f2py2.7 python2-numpy.src: W: spelling-error %description -l en_US numarray -> numeracy python2-numpy.src: W: spelling-error %description -l en_US fourier -> Fourier, courier, furrier python2-numpy.src: W: invalid-url Source1: https://docs.scipy.org/doc/numpy/numpy-html-1.16.1.zip HTTP Error 404: Not Found 6 packages and 0 specfiles checked; 54 errors, 39 warnings. Shouts a lot but this was already present in the old package. Rpmlint (debuginfo) ------------------- Checking: python2-numpy-debuginfo-1.16.4-4.fc31.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- python2-numpy-debuginfo.x86_64: W: invalid-url URL: http://www.numpy.org/ <urlopen error [Errno -2] Name or service not known> python2-numpy-doc.noarch: W: invalid-url URL: http://www.numpy.org/ <urlopen error [Errno -2] Name or service not known> python2-numpy-debugsource.x86_64: W: invalid-url URL: http://www.numpy.org/ <urlopen error [Errno -2] Name or service not known> python2-numpy.x86_64: W: spelling-error %description -l en_US numarray -> numeracy python2-numpy.x86_64: W: spelling-error %description -l en_US fourier -> Fourier, courier, furrier python2-numpy.x86_64: W: invalid-url URL: http://www.numpy.org/ <urlopen error [Errno -2] Name or service not known> python2-numpy.x86_64: E: library-not-linked-against-libc /usr/lib64/python2.7/site-packages/numpy/core/_dummy.so python2-numpy.x86_64: E: library-not-linked-against-libc /usr/lib64/python2.7/site-packages/numpy/core/_operand_flag_tests.so python2-numpy.x86_64: E: zero-length /usr/lib64/python2.7/site-packages/numpy/core/_aliased_types.py python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/__multiarray_api.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/__ufunc_api.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/_neighborhood_iterator_imp.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/_numpyconfig.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/arrayobject.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/arrayscalars.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/halffloat.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/ndarrayobject.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/ndarraytypes.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/noprefix.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/npy_1_7_deprecated_api.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/npy_3kcompat.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/npy_common.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/npy_cpu.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/npy_endian.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/npy_interrupt.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/npy_math.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/npy_no_deprecated_api.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/npy_os.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/numpyconfig.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/old_defines.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/oldnumeric.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/ufuncobject.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/include/numpy/utils.h python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/core/lib/libnpymath.a python2-numpy.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/distutils/conv_template.py 644 /usr/bin/env python python2-numpy.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/distutils/cpuinfo.py 644 /usr/bin/env python python2-numpy.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/distutils/from_template.py 644 /usr/bin/env python python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/distutils/mingw/gfortran_vs2003_hack.c python2-numpy.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/distutils/setup.py 644 /usr/bin/env python python2-numpy.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/distutils/system_info.py 644 /usr/bin/env python python2-numpy.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/ma/bench.py 644 /usr/bin/env python python2-numpy.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/ma/setup.py 644 /usr/bin/env python python2-numpy.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/matrixlib/setup.py 644 /usr/bin/env python python2-numpy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/random/randomkit.h python2-numpy.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/setup.py 644 /usr/bin/env python python2-numpy.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/testing/print_coercion_tables.py 644 /usr/bin/env python python2-numpy.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/testing/setup.py 644 /usr/bin/env python python2-numpy-f2py.x86_64: E: devel-dependency python2-devel python2-numpy-f2py.x86_64: W: summary-not-capitalized C f2py for numpy python2-numpy-f2py.x86_64: W: invalid-url URL: http://www.numpy.org/ <urlopen error [Errno -2] Name or service not known> python2-numpy-f2py.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/f2py/__init__.py 644 /usr/bin/env python python2-numpy-f2py.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/f2py/auxfuncs.py 644 /usr/bin/env python python2-numpy-f2py.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/f2py/capi_maps.py 644 /usr/bin/env python python2-numpy-f2py.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/f2py/cb_rules.py 644 /usr/bin/env python python2-numpy-f2py.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/f2py/cfuncs.py 644 /usr/bin/env python python2-numpy-f2py.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/f2py/common_rules.py 644 /usr/bin/env python python2-numpy-f2py.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/f2py/crackfortran.py 644 /usr/bin/env python python2-numpy-f2py.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/f2py/diagnose.py 644 /usr/bin/env python python2-numpy-f2py.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/f2py/f2py2e.py 644 /usr/bin/env python python2-numpy-f2py.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/f2py/f90mod_rules.py 644 /usr/bin/env python python2-numpy-f2py.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/f2py/func2subr.py 644 /usr/bin/env python python2-numpy-f2py.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/f2py/rules.py 644 /usr/bin/env python python2-numpy-f2py.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/f2py/setup.py 644 /usr/bin/env python python2-numpy-f2py.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/f2py/src/fortranobject.c python2-numpy-f2py.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/f2py/src/fortranobject.h python2-numpy-f2py.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/numpy/f2py/tests/src/array_from_pyobj/wrapmodule.c python2-numpy-f2py.x86_64: W: hidden-file-or-dir /usr/lib64/python2.7/site-packages/numpy/f2py/tests/src/assumed_shape/.f2py_f2cmap python2-numpy-f2py.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/numpy/f2py/use_rules.py 644 /usr/bin/env python python2-numpy-f2py.x86_64: W: no-manual-page-for-binary f2py2 python2-numpy-f2py.x86_64: W: no-manual-page-for-binary f2py2.7 5 packages and 0 specfiles checked; 29 errors, 41 warnings. Shouts a lot but this was already present in the old package. Source checksums ---------------- https://github.com/numpy/numpy/releases/download/v1.16.4/numpy-1.16.4.tar.gz : CHECKSUM(SHA256) this package : a3bccb70ad94091a5b9e2469fabd41ac877c140a6828c2022e35560a2ec0346c CHECKSUM(SHA256) upstream package : a3bccb70ad94091a5b9e2469fabd41ac877c140a6828c2022e35560a2ec0346c Requires -------- python2-numpy (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libm.so.6()(64bit) libopenblasp.so.0()(64bit) libpthread.so.0()(64bit) libpython2.7.so.1.0()(64bit) python(abi) python2.7dist(setuptools) rtld(GNU_HASH) python2-numpy-f2py (rpmlib, GLIBC filtered): /usr/bin/python2 python(abi) python2-devel python2-numpy python2-numpy-doc (rpmlib, GLIBC filtered): python2-numpy python2-numpy-debuginfo (rpmlib, GLIBC filtered): python2-numpy-debugsource (rpmlib, GLIBC filtered): Provides -------- python2-numpy: numpy numpy(x86-64) python2-numpy python2-numpy(x86-64) python2.7dist(numpy) python2dist(numpy) python2-numpy-f2py: f2py numpy-f2py python2-numpy-f2py python2-numpy-f2py(x86-64) python2-numpy-doc: python2-numpy-doc python2-numpy-debuginfo: debuginfo(build-id) python2-numpy-debuginfo python2-numpy-debuginfo(x86-64) python2-numpy-debugsource: python2-numpy-debugsource python2-numpy-debugsource(x86-64)
Note that all of the issues, were already present before. So technically, if you wish to disregard some, let me know.
Dropped static lib, fixed license tag and f2py Requires. Source 404 is due to upstream's doc publishing having moved on. Requiring gcc, though gcc-fortran requires it. SPEC: https://fedorapeople.org/~limb/review/python2-numpy/python2-numpy.spec SRPM: https://fedorapeople.org/~limb/review/python2-numpy/python2-numpy-1.16.4-4.fc30.src.rpm Also applied these fixes to the mainline numpy package.
# Everything is BSD except for class SafeEval in numpy/lib/utils.py which is Python License: BSD and Python and ASL 2.0 The comment is now not consistent with the tag. Apache License (v2.0) --------------------- numpy-1.16.4/doc/scipy-sphinx-theme/_theme/scipy/static/css/spc-bootstrap.css numpy-1.16.4/doc/scipy-sphinx-theme/_theme/scipy/static/less/bootstrap/bootstrap.less numpy-1.16.4/doc/scipy-sphinx-theme/_theme/scipy/static/less/bootstrap/responsive.less Those are only in python2-numpy-doc.
Oops. Tag fixed. SPEC: https://fedorapeople.org/~limb/review/python2-numpy/python2-numpy.spec SRPM: https://fedorapeople.org/~limb/review/python2-numpy/python2-numpy-1.16.4-4.fc30.src.rpm
Sorry to iterate over and over, but is the docs really just ASL? Isn't the docs BSD as well (with ASL css only)?
You're right, there is some BSD. Fixed. Want a new SRPM?
spec should be enough.
SPEC: https://fedorapeople.org/~limb/review/python2-numpy/python2-numpy.spec
Approved.
BTW https://src.fedoraproject.org/rpms/python2-numpy already exists (for EPEL), so request unretirement via https://pagure.io/releng/issues
Thanks! https://pagure.io/releng/issue/8572