Red Hat Bugzilla – Bug 173498
libtunepimp: A library for creating MusicBrainz enabled tagging applications
Last modified: 2007-11-30 17:11:17 EST
Spec Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/SPECS/libtunepimp-0.4.0-1.spec SRPM Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.unstable/libtunepimp-0.4.0-1.src.rpm Description: The TunePimp library (also referred to as libtunepimp) is a development library geared towards developers who wish to create MusicBrainz enabled tagging applications. %changelog * Thu Nov 17 2005 Rex Dieter <rexdieter[AT]users.sf.net> 0.4.0-1 - 0.4.0 - built with --enable-lgpl which omits mp3 plugin bits
Library (Theoretically) usable by: kdemultimedia(extras/juk), amarok
FYI, amarok requires patching to use the new libtunepimp, see http://bugs.kde.org/94988 kdemultimedia(-3.5.0) as well: http://bugs.kde.org/116575
Do you happen to have any info whether the current kid3 in Extras would work with this version? It should have support for libtunepimp, but I've never tried it out.
I'll go check it out.
Looks like kid3 uses code similar to both juk and amarok, and will need to be likewise patched (the api changed a wee bit from lintunepimp-0.3.0 to 0.4.0).
Missing BR: zlib-devel and libvorbis-devel. Also, it is BR: libmusicbrainz-devel and not BR: libmusicbrainz
FYI, see also libtunepimp-mp3 submission to livna: http://bugzilla.livna.org/show_bug.cgi?id=637
Spec Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/SPECS/libtunepimp-0.4.0-2.spec SRPM Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.unstable/libtunepimp-0.4.0-2.src.rpm %changelog * Sat Nov 19 2005 Rex Dieter <rexdieter[AT]users.sf.net> 0.4.0-2 - BR: libmusicbrainz -> libmusicbrainz-devel - BR: libogg-devel -> libvorbis-devel - BR: zlib-devel
Review for release 2: * RPM name is OK * Source libtunepimp-0.4.0.tar.gz is the same as upstream * This is the latest version * Builds fine in mock * rpmlint of libtunepimp looks OK * rpmlint of libtunepimp-devel looks OK * File list of libtunepimp looks OK * File list of libtunepimp-devel looks OK * Works fine APPROVED I've added the patch to amarok, will request a rebuild when this is published.
Thanks, imported.
No component for this yet in Bugzilla, so I'll spam here: some of the headers in -devel contain susceptible #includes that aren't shipped in it (and -devel has no other -devel deps, and even if it did, these would look more or less strange): track.h:#include "mutex.h" track.h:#include "metadata.h" track.h:#include "filelookup.h" tunepimp.h:#include "mutex.h" tunepimp.h:#include "filecache.h" tunepimp.h:#include "analyzer.h" tunepimp.h:#include "submit.h" tunepimp.h:#include "lookup.h" tunepimp.h:#include "filelookup.h" tunepimp.h:#include "write.h" tunepimp.h:#include "readmeta.h" tunepimp.h:#include "plugins.h"
Ville, Yeah, clearly the C++ API is not finalized, and some of the included headers don't seem 100% usable (ie, tunepimp.h). The only header I know that libtunepimp-using apps are actively using is tp_c.h.
Ok, in that case I'd suggest purging the currently unusable headers from the -devel package (track.h, tunepimp.h unless I missed something) in order to avoid confusion.