Spec Name or Url: http://home.arcor.de/christoph.wickert/fedora/extras-review/SPECS/xfce4-genmon-plugin.spec SRPM Name or Url: http://home.arcor.de/christoph.wickert/fedora/extras-review/SPECS/xfce4-genmon-plugin.spechttp://home.arcor.de/christoph.wickert/fedora/extras-review/SRPMS/xfce4-genmon-plugin-1.1-3.fc4.src.rpm Description: The GenMon plugin cyclically spawns the indicated script/program, captures its output and displays it as a string into the panel. Comments: rpmlint is clean License LGPL and included not sure if "string _into_ the panel" is good english? (but taken from website)
Sorry, SRPM is at http://home.arcor.de/christoph.wickert/fedora/extras-review/SRPMS/xfce4-genmon-plugin-1.1-3.fc4.src.rpm
good: - rpmlint is clean :) - License is good (LGPL). - builds fine on fc4/devel. (with missing BR added, see below) - installs and runs fine on my fc4 laptop. - builds fine in mock under devel if you add missing RB (see below) nits: - Might tell upstream that the spec they ship has the License as BSD, which is wrong. needswork: - source doesn't match upsteam. Looks like they recreated the tar in jan 2005, but you have the older version from 2004. - missing libxfcegui4-devel BuildRequires.
(In reply to comment #2) > > nits: > - Might tell upstream that the spec they ship has the License as BSD, which is > wrong. just like in bug #173105, this is a relict from a xfce4-panel-sample-plugin package. > > needswork: > - source doesn't match upsteam. Looks like they recreated the tar in jan 2005, > but you have the older version from 2004. fixed. > - missing libxfcegui4-devel BuildRequires. fixed. (Thanks for kickin my ass ;)) Also fixed %defattr(-,root,root,-) instead of (-,root,root) NEW SRPM: http://home.arcor.de/christoph.wickert/fedora/extras-review/SRPMS/xfce4-genmon-plugin-1.1-4.fc4.src.rpm
> just like in bug #173105, this is a relict from a xfce4-panel-sample-plugin package. well, not exactly. There they shipped a BSD LICENSE file, but the source files had LGPL headers. Here the only thing wrong is the spec file they ship (which we don't use). In this case it could just be a simple mistake in the spec, in the other one it's hard to say what they intended... This SRPM builds here, source matches, BuildRequires looks good. APPROVED.
Package Change Request ====================== Package Name: xfce4-genmon-plugin New Branches: epel7 Owners: cwickert InitialCC: nonamedotc
Git done (by process-git-requests).