Bug 173544 - Review Request: xfce4-genmon-plugin
Review Request: xfce4-genmon-plugin
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Kevin Fenzi
David Lawrence
http://xfce-goodies.berlios.de/
:
Depends On:
Blocks: FE-ACCEPT
  Show dependency treegraph
 
Reported: 2005-11-17 20:28 EST by Christoph Wickert
Modified: 2014-09-23 07:57 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2005-12-14 21:49:23 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Christoph Wickert 2005-11-17 20:28:08 EST
Spec Name or Url: 
http://home.arcor.de/christoph.wickert/fedora/extras-review/SPECS/xfce4-genmon-plugin.spec
SRPM Name or Url: 
http://home.arcor.de/christoph.wickert/fedora/extras-review/SPECS/xfce4-genmon-plugin.spechttp://home.arcor.de/christoph.wickert/fedora/extras-review/SRPMS/xfce4-genmon-plugin-1.1-3.fc4.src.rpm
Description: 
The GenMon plugin cyclically spawns the indicated script/program,
captures its output and displays it as a string into the panel.

Comments:
rpmlint is clean
License LGPL and included
not sure if "string _into_ the panel" is good english? (but taken from website)
Comment 2 Kevin Fenzi 2005-11-30 18:28:55 EST
good: 
- rpmlint is clean :)
- License is good (LGPL).
- builds fine on fc4/devel. (with missing BR added, see below)
- installs and runs fine on my fc4 laptop. 
- builds fine in mock under devel if you add missing RB (see below)

nits: 
- Might tell upstream that the spec they ship has the License as BSD, which is
wrong. 

needswork:
- source doesn't match upsteam. Looks like they recreated the tar in jan 2005,
but you have the older version from 2004. 
- missing libxfcegui4-devel BuildRequires. 
Comment 3 Christoph Wickert 2005-11-30 20:09:46 EST
(In reply to comment #2)
> 
> nits: 
> - Might tell upstream that the spec they ship has the License as BSD, which is
> wrong. 

just like in bug #173105, this is a relict from a xfce4-panel-sample-plugin package.

> 
> needswork:
> - source doesn't match upsteam. Looks like they recreated the tar in jan 2005,
> but you have the older version from 2004. 

fixed.

> - missing libxfcegui4-devel BuildRequires. 

fixed.
(Thanks for kickin my ass ;))

Also fixed %defattr(-,root,root,-) instead of (-,root,root)

NEW SRPM:
http://home.arcor.de/christoph.wickert/fedora/extras-review/SRPMS/xfce4-genmon-plugin-1.1-4.fc4.src.rpm
Comment 4 Kevin Fenzi 2005-12-01 00:31:22 EST
> just like in bug #173105, this is a relict from a xfce4-panel-sample-plugin
package.

well, not exactly. There they shipped a BSD LICENSE file, but the source files
had LGPL headers. Here the only thing wrong is the spec file they ship (which we
don't use). In this case it could just be a simple mistake in the spec, in the
other one it's hard to say what they intended... 

This SRPM builds here, source matches, BuildRequires looks good. 

APPROVED. 

Comment 5 Mukundan Ragavan 2014-09-22 21:09:15 EDT
Package Change Request
======================
Package Name:  xfce4-genmon-plugin
New Branches: epel7
Owners: cwickert
InitialCC: nonamedotc
Comment 6 Gwyn Ciesla 2014-09-23 07:57:43 EDT
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.