Red Hat Bugzilla – Bug 173544
Review Request: xfce4-genmon-plugin
Last modified: 2014-09-23 07:57:43 EDT
Spec Name or Url:
SRPM Name or Url:
The GenMon plugin cyclically spawns the indicated script/program,
captures its output and displays it as a string into the panel.
rpmlint is clean
License LGPL and included
not sure if "string _into_ the panel" is good english? (but taken from website)
Sorry, SRPM is at
- rpmlint is clean :)
- License is good (LGPL).
- builds fine on fc4/devel. (with missing BR added, see below)
- installs and runs fine on my fc4 laptop.
- builds fine in mock under devel if you add missing RB (see below)
- Might tell upstream that the spec they ship has the License as BSD, which is
- source doesn't match upsteam. Looks like they recreated the tar in jan 2005,
but you have the older version from 2004.
- missing libxfcegui4-devel BuildRequires.
(In reply to comment #2)
> - Might tell upstream that the spec they ship has the License as BSD, which is
just like in bug #173105, this is a relict from a xfce4-panel-sample-plugin package.
> - source doesn't match upsteam. Looks like they recreated the tar in jan 2005,
> but you have the older version from 2004.
> - missing libxfcegui4-devel BuildRequires.
(Thanks for kickin my ass ;))
Also fixed %defattr(-,root,root,-) instead of (-,root,root)
> just like in bug #173105, this is a relict from a xfce4-panel-sample-plugin
well, not exactly. There they shipped a BSD LICENSE file, but the source files
had LGPL headers. Here the only thing wrong is the spec file they ship (which we
don't use). In this case it could just be a simple mistake in the spec, in the
other one it's hard to say what they intended...
This SRPM builds here, source matches, BuildRequires looks good.
Package Change Request
Package Name: xfce4-genmon-plugin
New Branches: epel7
Git done (by process-git-requests).