Spec Name or Url: http://home.arcor.de/christoph.wickert/fedora/extras-review/SPECS/xfce4-mount-plugin.spec SRPM Name or Url: http://home.arcor.de/christoph.wickert/fedora/extras-review/SRPMS/xfce4-mount-plugin-0.3.2-2.fc4.src.rpm Description: Mount and unmount filesystems from the Xfce panel. Comments: This is not the latest upstream release but the latest to build on XFCE 4.2.x, modemlight-plugin-4.x series is for upcoming xfce 4.3 only. rpmlint is clean License GPL and included
- Add libxfcegui4-devel BuildReqs. - Fix %defattr. New SRPM: http://home.arcor.de/christoph.wickert/fedora/extras-review/SRPMS/xfce4-mount-plugin-0.3.2-3.fc4.src.rpm
Here is a detailed review: + mock succesfully built the srpms + rpmlint did not complain about errors + package conforms to the package guideline (spec name, version, ...) + versionning of the package follows Fedora Extras standards + tarball from upstream match with the tarball from source rpm. + package is under GPL license thus following legal section of PackagingGuidelines + no error encountered after installing and removing package Following this review, this package is ready to be in Fedora Extras thus changing the status to FE-ACCEPT.
Forgot to add on this quote: + tarball from upstream match with the tarball from source rpm. I used both md5sum and sha1sum
(In reply to comment #3) > > I used both md5sum and sha1sum one should be enough ;) Updated the package to 0.3.3 after import into cvs. 0.3.3-1 builds fine on Core 3 and 4, rawhide is inconsistent atm. Closing.