Bug 1735753 - Review Request: perl-Mojo-DOM58 - Minimalistic HTML/XML DOM parser with CSS selectors
Summary: Review Request: perl-Mojo-DOM58 - Minimalistic HTML/XML DOM parser with CSS s...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-08-01 12:03 UTC by Petr Pisar
Modified: 2019-08-02 13:42 UTC (History)
2 users (show)

Fixed In Version: perl-Mojo-DOM58-2.000-1.fc31
Clone Of:
Environment:
Last Closed: 2019-08-02 13:42:03 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2019-08-01 12:03:45 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Mojo-DOM58/perl-Mojo-DOM58.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Mojo-DOM58/perl-Mojo-DOM58-2.000-1.fc31.src.rpm
Description:
Mojo::DOM58 is a minimalistic and relaxed pure-perl HTML/XML DOM parser. It
supports the HTML Living Standard and Extensible Markup Language (XML) 1.0,
and matching based on CSS3 selectors. It will even try to interpret broken
HTML and XML, so you should not use it for validation.

Fedora Account System Username: ppisar

Comment 1 Robert-André Mauchin 🐧 2019-08-01 20:45:24 UTC
URL and Source addresses are Ok.
Source archive (SHA-256: 864c6a3571fb4986a9ae0af0f2c840acb102f1f73a1aaf027b06b42b8d045ef3) is original. Ok.
Summary verified from lib/Mojo/DOM58.pm. Ok.
Description verified from lib/Mojo/DOM58.pm. Ok.
License verified from lib/Mojo/DOM58.pm and README. Ok.
No XS code, noarch BuildArch is Ok.

$ rpmlint perl-Mojo-DOM58.spec review-perl-Mojo-DOM58/results/perl-Mojo-DOM58-2.000-1.fc31.noarch.rpm  review-perl-Mojo-DOM58/results/perl-Mojo-DOM58-2.000-1.fc31.src.rpm 
perl-Mojo-DOM58.noarch: W: spelling-error Summary(en_US) Minimalistic -> Minimalist, Minimalism, Animistic
perl-Mojo-DOM58.noarch: W: spelling-error %description -l en_US minimalistic -> minimalist, minimalism, animistic
perl-Mojo-DOM58.src: W: spelling-error Summary(en_US) Minimalistic -> Minimalist, Minimalism, Animistic
perl-Mojo-DOM58.src: W: spelling-error %description -l en_US minimalistic -> minimalist, minimalism, animistic
2 packages and 1 specfiles checked; 0 errors, 4 warnings.

$ rpm -q -lv -p perl-Mojo-DOM58-2.000-1.fc31.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Aug  1 22:33 /usr/share/doc/perl-Mojo-DOM58
-rw-r--r--    1 root    root                     4430 Dec 18  2018 /usr/share/doc/perl-Mojo-DOM58/CONTRIBUTING.md
-rw-r--r--    1 root    root                     2479 Dec 18  2018 /usr/share/doc/perl-Mojo-DOM58/Changes
-rw-r--r--    1 root    root                    37658 Dec 18  2018 /usr/share/doc/perl-Mojo-DOM58/README
drwxr-xr-x    2 root    root                        0 Dec 18  2018 /usr/share/doc/perl-Mojo-DOM58/examples
-rw-r--r--    1 root    root                      507 Dec 18  2018 /usr/share/doc/perl-Mojo-DOM58/examples/entities.pl
drwxr-xr-x    2 root    root                        0 Aug  1 22:33 /usr/share/licenses/perl-Mojo-DOM58
-rw-r--r--    1 root    root                     9037 Dec 18  2018 /usr/share/licenses/perl-Mojo-DOM58/LICENSE
-rw-r--r--    1 root    root                    10871 Aug  1 22:32 /usr/share/man/man3/Mojo::DOM58.3pm.gz
-rw-r--r--    1 root    root                     1975 Aug  1 22:32 /usr/share/man/man3/Mojo::DOM58::Entities.3pm.gz
drwxr-xr-x    2 root    root                        0 Aug  1 22:32 /usr/share/perl5/vendor_perl/Mojo
drwxr-xr-x    2 root    root                        0 Aug  1 22:32 /usr/share/perl5/vendor_perl/Mojo/DOM58
-rw-r--r--    1 root    root                    45680 Dec 18  2018 /usr/share/perl5/vendor_perl/Mojo/DOM58.pm
-rw-r--r--    1 root    root                    40806 Dec 18  2018 /usr/share/perl5/vendor_perl/Mojo/DOM58/Entities.pm
-rw-r--r--    1 root    root                     9465 Dec 18  2018 /usr/share/perl5/vendor_perl/Mojo/DOM58/_CSS.pm
-rw-r--r--    1 root    root                     3241 Dec 18  2018 /usr/share/perl5/vendor_perl/Mojo/DOM58/_Collection.pm
-rw-r--r--    1 root    root                     9238 Dec 18  2018 /usr/share/perl5/vendor_perl/Mojo/DOM58/_HTML.pm
File permissions and layout are Ok.


$ rpm -q --requires -p perl-Mojo-DOM58-2.000-1.fc31.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.30.0)
      1 perl(Carp)
      1 perl(constant)
      1 perl(Exporter) >= 5.57
      1 perl(List::Util)
      1 perl(Mojo::DOM58::Entities)
      1 perl(Mojo::DOM58::_Collection)
      1 perl(Mojo::DOM58::_CSS)
      1 perl(Mojo::DOM58::_HTML)
      1 perl(overload)
      1 perl(Scalar::Util)
      1 perl(Storable)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.

$ rpm -q --provides -p perl-Mojo-DOM58-2.000-1.fc31.noarch.rpm 
perl(Mojo::DOM58) = 2.000
perl(Mojo::DOM58::Entities) = 2.000
perl(Mojo::DOM58::_CSS) = 2.000
perl(Mojo::DOM58::_Collection) = 2.000
perl(Mojo::DOM58::_HTML) = 2.000
perl-Mojo-DOM58 = 2.000-1.fc31
Binary provides are Ok.

Package builds in Koji (https://koji.fedoraproject.org/koji/taskinfo?taskID=36741657).
Ok


Resolution: Package approved.

Comment 2 Gwyn Ciesla 2019-08-02 13:12:34 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Mojo-DOM58

Comment 3 Petr Pisar 2019-08-02 13:42:03 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.