Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-zmap-zcrypto.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-zmap-zcrypto-0-0.1.20190801git9051775.fc31.src.rpm Description: Liberal Go TLS + X.509 Library for Research. Fedora Account System Username: eclipseo
Here is a successful Koji scratch build. https://koji.fedoraproject.org/koji/taskinfo?taskID=36925497
Hello Robert-André, The LICENSE: field should be "ISC and MIT and ASL 2.0" because some files are licensed under BSD-style license and MIT although some files are under ASL 2.0. Please check the upstream LICENSE file. https://github.com/zmap/zcrypto/blob/master/LICENSE Here are logs for reference. 1. rpmlint ``` $ rpmlint golang-github-zmap-zcrypto-0-0.1.20190801git9051775.fc31.src.rpm golang-github-zmap-zcrypto.src: W: no-%build-section 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint ~/rpmbuild/RPMS/noarch/golang-github-zmap-zcrypto-devel-0-0.1.20190801git9051775.fc31~bootstrap.noarch.rpm golang-github-zmap-zcrypto-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/zmap/zcrypto/.goipath 1 packages and 0 specfiles checked; 0 errors, 1 warnings. ``` 2. fedora-review fedora-review fails because 'golang(github.com/zmap/rc2)' package still doesn't exist. I manually installed that package and tested golang-github-zmap-zcrypto package. ``` ERROR: Command failed: # /usr/bin/dnf builddep --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 31 --setopt=deltarpm=False --disableplugin=local --disableplug\ in=spacewalk /var/lib/mock/fedora-rawhide-x86_64/root//builddir/build/SRPMS/golang-github-zmap-zcrypto-0-0.1.20190801git9051775.fc31~bootstrap.src.rpm No matches found for the following disable plugin patterns: local, spacewalk fedora 4.9 kB/s | 6.2 kB 00:01 No matching package to install: 'golang(github.com/zmap/rc2)' ``` Thanks in advance, Hirotaka Wakabayashi
Thanks, I hadn't checked that.
New Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-zmap-zcrypto.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-zmap-zcrypto-0-0.1.20190801git9051775.fc31.src.rpm
golang(github.com/zmap/rc2) should be in Rawhide by the next compose. I built it yesterday.
(In reply to Robert-André Mauchin from comment #5) Hello Robert-André, Thanks for your fix. I confirmed it. This package meets requirements for quality. > golang(github.com/zmap/rc2) should be in Rawhide by the next compose. I > built it yesterday. Thank you for letting me know. I couldn't find that package in the nightly Fedora-Rawhide-20190811.n.1. But I think it is not a problem because I have manually reviewed golang-github-zmap-zcrypto. The followings are logs for reference. 1. rpmlint ``` $ rpmlint golang-github-zmap-zcrypto-0-0.1.20190801git9051775.fc31.src.rpm golang-github-zmap-zcrypto.src: W: no-%build-section 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint ~/rpmbuild/RPMS/noarch/golang-github-zmap-zcrypto-devel-0-0.1.20190801git9051775.fc31~bootstrap.noarch.rpm golang-github-zmap-zcrypto-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/zmap/zcrypto/.goipath 1 packages and 0 specfiles checked; 0 errors, 1 warnings. ``` 2. a successful koji scratch build https://koji.fedoraproject.org/koji/taskinfo?taskID=36942354 Best Regards, Hirotaka Wakabayashi
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-zmap-zcrypto