Bug 1736461 - pulseaudio-equalizer: FTBFS in Fedora rawhide/f31
Summary: pulseaudio-equalizer: FTBFS in Fedora rawhide/f31
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: pulseaudio-equalizer
Version: 31
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Shawn Starr
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F31FTBFS 1732841
TreeView+ depends on / blocked
 
Reported: 2019-08-01 17:46 UTC by Fedora Release Engineering
Modified: 2019-12-16 02:51 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-09-22 11:30:13 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
build.log (7.10 KB, text/plain)
2019-08-01 17:47 UTC, Fedora Release Engineering
no flags Details
root.log (32.00 KB, text/plain)
2019-08-01 17:47 UTC, Fedora Release Engineering
no flags Details
state.log (669 bytes, text/plain)
2019-08-01 17:47 UTC, Fedora Release Engineering
no flags Details
This changes the python to explicit python3 and puts parentheses on the print statements. (2.66 KB, patch)
2019-08-04 18:57 UTC, stan
no flags Details | Diff
This is the spec with the attached patch added to it. (5.55 KB, text/plain)
2019-08-04 18:58 UTC, stan
no flags Details
Converts all tabs to spaces with a tabstop of 8 in order to correct indentation problems. (29.03 KB, patch)
2019-08-08 13:39 UTC, stan
no flags Details | Diff

Description Fedora Release Engineering 2019-08-01 17:46:59 UTC
pulseaudio-equalizer failed to build from source in Fedora rawhide/f31

https://koji.fedoraproject.org/koji/taskinfo?taskID=36637023


For details on the mass rebuild see:

https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild
Please fix pulseaudio-equalizer at your earliest convenience and set the bug's status to
ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks,
pulseaudio-equalizer will be orphaned. Before branching of Fedora 32,
pulseaudio-equalizer will be retired, if it still fails to build.

For more details on the FTBFS policy, please visit:
https://fedoraproject.org/wiki/Fails_to_build_from_source

Comment 1 Fedora Release Engineering 2019-08-01 17:47:02 UTC
Created attachment 1598677 [details]
build.log

Comment 2 Fedora Release Engineering 2019-08-01 17:47:15 UTC
Created attachment 1598678 [details]
root.log

file root.log too big, will only attach last 32768 bytes

Comment 3 Fedora Release Engineering 2019-08-01 17:47:17 UTC
Created attachment 1598679 [details]
state.log

Comment 4 stan 2019-08-04 18:56:20 UTC
After the mass rebuild the version of pulseaudio-equalizer from f29 no longer worked on f31.  When I got the latest source, the f29 src.rpm, and built it locally, it failed to build because the shebang was ambiguous, python instead of python2 or python3.  I fixed it to be python3, and converted all the print statements, and the package built fine, and installed fine.  Note that I have also built the ladspa-swh-plugin package from the f29 src.rpm locally and installed it.  Pulseaudio-equalizer requires that package to function.

So after I installed the 'fixed' package, it will not start.  These are the errors in journalctl -r.

Aug 04 11:41:16 localhost.Home dbus-broker-launch[8629]: Activation request for 'org.a11y.atspi.Registry' failed.
Aug 04 11:41:16 localhost.Home dbus-daemon[8401]: [session uid=9999 pid=8399] Activated service 'org.freedesktop.systemd1' failed: Process org.freedesktop.systemd1 exited with status 1
Aug 04 11:41:16 localhost.Home dbus-daemon[8401]: [session uid=9999 pid=8399] Activating service name='org.freedesktop.systemd1' requested by ':1.31' (uid=9999 pid=8629 comm="/usr/bin/dbus-broker-launch --config-file=/usr/sha" label="unconfined_u:unconfined_r:unconfined_dbusd_t:s0-s0:c0.c1023")
Aug 04 11:41:16 localhost.Home dbus-broker-launch[8629]: Activation request for 'org.a11y.atspi.Registry' failed.
Aug 04 11:41:16 localhost.Home dbus-daemon[8401]: [session uid=9999 pid=8399] Activated service 'org.freedesktop.systemd1' failed: Process org.freedesktop.systemd1 exited with status 
Aug 04 11:41:16 localhost.Home dbus-daemon[8401]: [session uid=9999 pid=8399] Activating service name='org.freedesktop.systemd1' requested by ':1.31' (uid=9999 pid=8629 comm="/usr/bin/dbus-broker-launch --config-file=/usr/sha" label="unconfined_u:unconfined_r:unconfined_dbusd_t:s0-s0:c0.c1023")

The system is running in permissive SELinux mode because systemd can't create terminals in multiuser using systemd-logind if it isn't.  So, I don't think the labeling should have caused a problem, but maybe it did.

The same failure occurs if I change the version of python to be python2 explicitly.

I've attached the patch I added to allow it to build, and the spec file that uses that patch.

Comment 5 stan 2019-08-04 18:57:54 UTC
Created attachment 1600431 [details]
This changes the python to explicit python3 and puts parentheses on the print statements.

Comment 6 stan 2019-08-04 18:58:49 UTC
Created attachment 1600432 [details]
This is the spec with the attached patch added to it.

Comment 7 stan 2019-08-07 03:34:04 UTC
An update:

I was able to update pulseaudio to the 12.99 version.  I then rebuilt the ladspa-swh-plugins package, reinstalled it, and built the pulseaudio-equalizer package.  Both were built from the F29 src.rpm using rpmbuild locally, and both reinstalled without error.  When I then try to start pulseaudio-equalizer, I get the following errors in journalctl -r.

Aug 06 18:47:31 localhost.localdomain dbus-broker-launch[8238]: Activation request for 'org.a11y.atspi.Registry' failed.
Aug 06 18:47:31 localhost.localdomain dbus-daemon[8033]: [session uid=9999 pid=8031] Activated service 'org.freedesktop.systemd1' failed: Process org.freedesktop.systemd1 exited with status 1
Aug 06 18:47:31 localhost.localdomain dbus-daemon[8033]: [session uid=9999 pid=8031] Activating service name='org.freedesktop.systemd1' requested by ':1.26' (uid=9999 pid=8238 comm="/usr/bin/dbus-broker-launch --config-file=/usr/sha" label="unconfined_u:unconfined_r:unconfined_dbusd_t:s0-s0:c0.c1023")
Aug 06 18:47:30 localhost.localdomain dbus-broker-launch[8238]: Activation request for 'org.a11y.atspi.Registry' failed.
Aug 06 18:47:30 localhost.localdomain dbus-daemon[8033]: [session uid=9999 pid=8031] Activated service 'org.freedesktop.systemd1' failed: Process org.freedesktop.systemd1 exited with status 1
Aug 06 18:47:30 localhost.localdomain dbus-daemon[8033]: [session uid=9999 pid=8031] Activating service name='org.freedesktop.systemd1' requested by ':1.26' (uid=9999 pid=8238 comm="/usr/bin/dbus-broker-launch --config-file=/usr/sha" label="unconfined_u:unconfined_r:unconfined_dbusd_t:s0-s0:c0.c1023")
Aug 06 18:47:04 localhost.localdomain abrt-server[49077]: Deleting problem directory '/var/spool/abrt/Python3-2019-08-06-18:47:04-49076'
Aug 06 18:47:04 localhost.localdomain abrt-server[49077]: 'post-create' on '/var/spool/abrt/Python3-2019-08-06-18:47:04-49076' exited with 1
Aug 06 18:47:04 localhost.localdomain abrt-server[49077]: Package 'pulseaudio-equalizer' isn't signed with proper key
Aug 06 18:47:04 localhost.localdomain python[49076]: detected unhandled Python exception in '/usr/share/pulseaudio-equalizer/pulseaudio-equalizer.py'
Aug 06 18:47:02 localhost.localdomain dbus-broker-launch[8238]: Activation request for 'org.a11y.atspi.Registry' failed.
Aug 06 18:47:02 localhost.localdomain dbus-daemon[8033]: [session uid=9999 pid=8031] Activated service 'org.freedesktop.systemd1' failed: Process org.freedesktop.systemd1 exited with status 1
Aug 06 18:47:02 localhost.localdomain dbus-daemon[8033]: [session uid=9999 pid=8031] Activating service name='org.freedesktop.systemd1' requested by ':1.26' (uid=9999 pid=8238 comm="/usr/bin/dbus-broker-launch --config-file=/usr/sha" label="unconfined_u:unconfined_r:unconfined_dbusd_t:s0-s0:c0.c1023")
Aug 06 18:47:02 localhost.localdomain dbus-broker-launch[8238]: Activation request for 'org.a11y.atspi.Registry' failed.
Aug 06 18:47:02 localhost.localdomain dbus-daemon[8033]: [session uid=9999 pid=8031] Activated service 'org.freedesktop.systemd1' failed: Process org.freedesktop.systemd1 exited with status 1
Aug 06 18:47:02 localhost.localdomain dbus-daemon[8033]: [session uid=9999 pid=8031] Activating service name='org.freedesktop.systemd1' requested by ':1.26' (uid=9999 pid=8238 comm="/usr/bin/dbus-broker-launch --config-file=/usr/sha" label="unconfined_u:unconfined_r:unconfined_dbusd_t:s0-s0:c0.c1023")

I don't understand how the package pulseaudio-equalizer is not signed with the proper key.  I've built lots of src.rpm packages locally this way without problem.  What does that even mean?

Comment 8 stan 2019-08-07 03:51:00 UTC
After thinking about it, the message about the improper key is from abrt.  The actual problem is the unhandled exception.  So, I ran the program from a terminal, and it turns out that there were mixed tabs and spaces for indentation.  When I edited the file, it reset to spaces for all whitespace.  Disaster!  I'll clean it up, and it should probably build and run fine after that.

Comment 9 stan 2019-08-08 13:36:27 UTC
After cleaning up the indentation by replacing everything with spaces when using a tabstop of 8, the code looks ugly, but the indentation is correct.  I then discovered that this program has a python2 problem.  The modules used are for python2 only, and do not exist for python3.  I don't even see any similar modules.  This uses gtk2, and the modules pygtk and gtk.  I don't find py3gtk2 or py3gtk3 or gtk3 modules.  I suspect the interface has changed in gtk3; that's a show stopper for me as I don't know gtk at all, so it would be hard to translate the gtk2 code to gtk3.  In the future the only way to use this will be with legacy python2 or possibly as a module that contains all the necessary obsolete plumbing.

I think this is just an indicator that the end of python2 is going to remove a lot of functionality from linux.

I'll attach the patch that fixes the indentation errors.  The previous patch that converted to python3 is obviously not needed anymore, so this patch can replace it in the spec file.

Comment 10 stan 2019-08-08 13:39:19 UTC
Created attachment 1601814 [details]
Converts all tabs to spaces with a tabstop of 8 in order to correct indentation problems.

This can be used instead of the python3 conversion patch, as that is no longer necessary since the program is indelibly python2.  Or, it can be used in addition to the python3 conversion patch with the python3 in the first line changed to python2.

Comment 11 stan 2019-08-08 13:42:22 UTC
The program run as python2 no longer starts from the menu or a desktop icon.  It has to be invoked explicitly as
python2 /usr/share/pulseaudio-equalizer/pulseaudio-equalizer.py
in a terminal.  It then runs fine.

Comment 12 Ben Cotton 2019-08-13 16:47:42 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to '31'.

Comment 13 Fedora Release Engineering 2019-09-22 04:34:03 UTC
Dear Maintainer,

your package has not been built successfully in 31. Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. Following the latest policy for such packages [2], your package
can be orphaned if this bug remains in NEW state more than 8 weeks.

A week before the mass branching of Fedora 32 according to the schedule [3],
any packages which still have open FTBFS bugs from Fedora 31 will be retired.

[1] https://fedoraproject.org/wiki/Updates_Policy
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedoraproject.org/wiki/Releases/32/Schedule

Comment 14 Miro Hrončok 2019-09-22 11:30:13 UTC
Automation has figured out the package is retired in Fedora 31.

If you like it to be unretired, please open a ticket at https://pagure.io/releng/new_issue?template=package_unretirement


Note You need to log in before you can comment on or make changes to this bug.