Spec Name or Url: http://home.arcor.de/christoph.wickert/fedora/extras-review/SPECS/xfce4-cpugraph-plugin.spec SRPM Name or Url: http://home.arcor.de/christoph.wickert/fedora/extras-review/SRPMS/xfce4-cpugraph-plugin-0.2.2-3.fc4.src.rpm Description: A CPU monitor plugin for the Xfce panel. It offers multiple display modes (LED, gradient, fire, etc...) to show the current CPU load of the system. The colors and the size of the plugin are customizable. Comments: rpmlint is clean license BSD and included
Hi Christoph, heres a quick review: needswork: - upstream tarball is slightly different: - dir name: xfce4-cpugraph-plugin-0.2.2 not xfce4-cpugraph-plugin which can be corrected with "setup -q -n %{name} - upstream tarball includes a specfile - build in mock on FC-4 fails with: checking for xfce4-panel-1.0 >= 4.0.0... Package libxfcegui4-1.0 was not found in the pkg-config search path good: + builds on FC-4 (not in mock) + rpmlint OK + license OK and included + spec file looks good (very simple!) + code not content, etc. and do you have any idea why the mock build is failing for me? I don't understand whats happening...
(In reply to comment #1) > Hi Christoph, heres a quick review: Thanks Ed, sorry for replying so late. > - upstream tarball is slightly different: > - dir name: xfce4-cpugraph-plugin-0.2.2 not xfce4-cpugraph-plugin > which can be corrected with "setup -q -n %{name} > - upstream tarball includes a specfile oops, sorry, looks like I used the source from the srpm and obviously it's not the same than the tarball. I've rebuild the package with the correct Source0. > and do you have any idea why the mock build is failing for me? I don't > understand whats happening... the libxfcegui4-devel package is missing. I thought it would be pulled in automatically by xfce4-panel-devel, but this was wrong. So I had to add libxfcegui4-devel to BuildReqs. New SRPM: http://home.arcor.de/christoph.wickert/fedora/extras-review/SRPMS/xfce4-cpugraph-plugin-0.2.2-4.fc4.src.rpm Updated SPEC: http://home.arcor.de/christoph.wickert/fedora/extras-review/SPECS/xfce4-cpugraph-plugin.spec
Hi Christoph, I get a "404 Not Found" for the SRPM in comment #2 above. And the SRPMS directory doesn't contain any newer versions, just the older 0.2.2-3 version.
Sorry, forgot to upload the SRPM. Now it's there.
Hi Christoph, the new SPRM looks good: + source matches upstream + builds in mock on FC-4 + no errors or warnings with rpmlint + no dangling directories APPROVED.
Hi Ed, thanks for your work. Package build successfully on all arches and braches.
Package Change Request ====================== Package Name: xfce4-cpugraph-plugin New Branches: epel7 Owners: cwickert InitialCC: nonamedotc
Git done (by process-git-requests).