Spec Name or Url: http://home.arcor.de/christoph.wickert/fedora/extras-review/SPECS/xfce4-fsguard-plugin.spec SRPM Name or Url: http://home.arcor.de/christoph.wickert/fedora/extras-review/SRPMS/xfce4-fsguard-plugin-0.2.1-1.fc4.src.rpm Description: A little Xfce plugin, which checks the free space on the chosen mountpoint frequently. It displays 4 different icons and a message box, depending on the free space. The amount of free disk space is visible in a tooltip. If you left-click on its icon, it opens the mountpoint directory in the file manager. Comments: rpmlint clean license BSD and included
- Add libxfcegui4-devel BuildReqs. - Fix %defattr. New SRPM: http://home.arcor.de/christoph.wickert/fedora/extras-review/SRPMS/xfce4-fsguard-plugin-0.2.1-2.fc4.src.rpm
Spec is good. Mock succesfully built from SRPMS, rpmlint passed. Set to FE-ACCEPT. Congragulation.
More detailed review: + mock succesfully build the package without noticeable error + rpmlint did not report any error nor warning + tarball from SRPM matched source tarball for URL listed on SPEC file through md5 and sha1 + binary package installed and removed without noticeable issue + name of the package/SPEC files follow PackagingGuide and PackageNameGuideline http://fedoraproject.org/wiki/PackagingGuidelines http://fedoraproject.org/wiki/PackageNamingGuidelines + License listed on SPEC file matched the license in the tarball and it is GPL-compatible http://www.gnu.org/philosophy/license-list.html#GPLCompatibleLicenses Accordingly, the package is ready to be included on Fedora Extras.
Build on all targets succeeded. CLOSED.