Bug 173670 - Review Request: xfce4-wavelan-plugin
Review Request: xfce4-wavelan-plugin
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Ed Hill
David Lawrence
http://xfce-goodies.berlios.de/
:
Depends On:
Blocks: FE-ACCEPT
  Show dependency treegraph
 
Reported: 2005-11-18 15:58 EST by Christoph Wickert
Modified: 2014-09-23 08:00 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2005-12-30 16:17:06 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Christoph Wickert 2005-11-18 15:58:46 EST
Spec Name or Url: 
http://home.arcor.de/christoph.wickert/fedora/extras-review/SPECS/xfce4-wavelan-plugin.spec
SRPM Name or Url: 
http://home.arcor.de/christoph.wickert/fedora/extras-review/SRPMS/xfce4-wavelan-plugin-0.4.1-3.fc4.src.rpm
Description: 
A plugin for the Xfce panel that monitors a wireless LAN interface. It displays stats for signal state, signal quality and network name (SSID).

Comments:
rpmlint clean
license BSD included
Comment 1 Christoph Wickert 2005-11-30 21:14:46 EST
- Add libxfcegui4-devel BuildReqs.
- Fix %defattr.

New SRPM:
http://home.arcor.de/christoph.wickert/fedora/extras-review/SRPMS/xfce4-wavelan-plugin-0.4.1-4.fc4.src.rpm
Comment 2 Ed Hill 2005-12-14 23:24:01 EST
Hi Christoph, heres a review:

good:
 + name OK
 + source matches upstream
 + clean, simple, and legible specfile
 + license is correct (BSD) and included (good)
 + builds in mock on FC-4
 + no rpmlint errors or warnings
 + dir ownership is OK
 + installs and works without segfaults on FC-4

This package is very simple and I don't see anything the matter with it
so its APPROVED.
Comment 3 Christoph Wickert 2005-12-30 16:17:06 EST
Thanks for the review. Package builds fine on all branches & arches.
Comment 4 Mukundan Ragavan 2014-09-22 21:08:19 EDT
Package Change Request
======================
Package Name:  xfce4-wavelan-plugin
New Branches: epel7
Owners: cwickert
InitialCC: nonamedotc
Comment 5 Jon Ciesla 2014-09-23 08:00:15 EDT
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.