Spec Name or Url: http://home.arcor.de/christoph.wickert/fedora/extras-review/SPECS/xfce4-wavelan-plugin.spec SRPM Name or Url: http://home.arcor.de/christoph.wickert/fedora/extras-review/SRPMS/xfce4-wavelan-plugin-0.4.1-3.fc4.src.rpm Description: A plugin for the Xfce panel that monitors a wireless LAN interface. It displays stats for signal state, signal quality and network name (SSID). Comments: rpmlint clean license BSD included
- Add libxfcegui4-devel BuildReqs. - Fix %defattr. New SRPM: http://home.arcor.de/christoph.wickert/fedora/extras-review/SRPMS/xfce4-wavelan-plugin-0.4.1-4.fc4.src.rpm
Hi Christoph, heres a review: good: + name OK + source matches upstream + clean, simple, and legible specfile + license is correct (BSD) and included (good) + builds in mock on FC-4 + no rpmlint errors or warnings + dir ownership is OK + installs and works without segfaults on FC-4 This package is very simple and I don't see anything the matter with it so its APPROVED.
Thanks for the review. Package builds fine on all branches & arches.
Package Change Request ====================== Package Name: xfce4-wavelan-plugin New Branches: epel7 Owners: cwickert InitialCC: nonamedotc
Git done (by process-git-requests).