Spec Name or Url: http://home.arcor.de/christoph.wickert/fedora/extras-review/SPECS/xfce4-xmms-plugin.spec SRPM Name or Url: http://home.arcor.de/christoph.wickert/fedora/extras-review/SRPMS/xfce4-xmms-plugin-0.3.1-3.fc4.src.rpm Description: Control XMMS from the Xfce panel. Comments: rpmlint clan license BSD included
spec looks good but built failed on rawhide on this line: checking for xfce4-panel-1.0 >= 4.0.0... Package libxfcegui4-1.0 was not found in the pkg-config search path. Perhaps you should add the directory containing `libxfcegui4-1.0.pc' to the PKG_CONFIG_PATH environment variable Package 'libxfcegui4-1.0', required by 'xfce4-panel', not found configure: error: Library requirements (xfce4-panel-1.0 >= 4.0.0) not met; consider adjusting the PKG_CONFIG_PATH environment variable if your libraries are in a nonstandard prefix so pkg-config can find them. error: Bad exit status from /var/tmp/rpm-tmp.68902 (%build) - Add libxfcegui4-1.0 as requirement
- Add libxfcegui4-devel BuildReqs. - Fix %defattr. New SRPM: http://home.arcor.de/christoph.wickert/fedora/extras-review/SRPMS/xfce4-xmms-plugin-0.3.1-4.fc4.src.rpm SPEC still at http://home.arcor.de/christoph.wickert/fedora/extras-review/SPECS/xfce4-xmms-plugin.spec
Hello, I completed the review of this packages. It succesfully passed and complied to the package guideline http://fedoraproject.org/wiki/PackagingGuidelines. The package is now set to FE-ACCEPTED.
Thanks for the review. Package will be released for Core 4 and devel soon. Won't build on Core 3 because pango is out of date there.
Perhaps by lowering pango version on the spec file this package will be built for FC3.
(In reply to comment #5) > Perhaps by lowering pango version on the spec file this package will be built > for FC3. Nope, the version is not in the spec file but in configure.ac. This plugin _needs_ pango >= 1.8.0 while Core 3 comes with 1.6.0.