Bug 1736807 - appliance-creator fails on "Writing GRUB Legacy config." on aarch64 EC2
Summary: appliance-creator fails on "Writing GRUB Legacy config." on aarch64 EC2
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: appliance-tools
Version: 31
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: ARMTracker
TreeView+ depends on / blocked
 
Reported: 2019-08-02 05:28 UTC by Warren Togami
Modified: 2019-08-13 18:33 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:


Attachments (Terms of Use)

Description Warren Togami 2019-08-02 05:28:47 UTC
Description of problem:
Fedora 30 aarch64 appliance-creator invoked with the cmdline and kickstart config from Bug #1736804 fails with this traceback.

Writing kickstart file.
Writing GRUB Legacy config.
Traceback (most recent call last):
  File "/usr/bin/appliance-creator", line 193, in <module>
    sys.exit(main())
  File "/usr/bin/appliance-creator", line 155, in main
    creator.configure()
  File "/usr/lib/python3.7/site-packages/imgcreate/creator.py", line 799, in configure
    self._create_bootconfig()
  File "/usr/lib/python3.7/site-packages/appcreate/appliance.py", line 536, in _create_bootconfig
    self._create_grub_config()
  File "/usr/lib/python3.7/site-packages/appcreate/appliance.py", line 286, in _create_grub_config
    grub += "splashimage=(hd0,%d)%s/grub/splash.xpm.gz\n" % (bootdevnum, prefix)
TypeError: %d format: a number is required, not NoneType

/usr/lib/python3.7/site-packages/appcreate/appliance.py line 536 ...
    def _create_bootconfig(self):
        logging.debug("Writing kickstart file.")
        self._write_kickstart()
        # For EC2 lets make a grub Legacy config file
        # (only if bootloader is enabled)
        if ((hasattr(self.ks.handler.bootloader, "disabled") and self.ks.handler.bootloader.disabled is False) and
           (hasattr(self.ks.handler.bootloader, "location") and self.ks.handler.bootloader.location != "none")):
            logging.debug("Writing GRUB Legacy config.")
            self._create_grub_config()

I'm guessing GRUB Legacy is meant only for x86_64, and nobody tried aarch64 appliance-creator on EC2 aarch64 recently?


Version-Release number of selected component (if applicable):
appliance-tools-009.0-5.fc30.noarch

Comment 1 Warren Togami 2019-08-05 14:14:31 UTC
https://pagure.io/appliance-tools/c/96b4e257892d4695b5ffe61ddf0e3586acf5de2f?branch=master
This traceback was introduced in this commit during late 2018.

I suspect nobody noticed this error because imagefactory is used for aarch64 images instead of appliance-creator.

Comment 2 Ben Cotton 2019-08-13 17:10:01 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to '31'.

Comment 3 Ben Cotton 2019-08-13 18:33:19 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to 31.


Note You need to log in before you can comment on or make changes to this bug.