Bug 1737045 - org.fedoraproject.FirewallD1.config.service.getIncludes returns exception
Summary: org.fedoraproject.FirewallD1.config.service.getIncludes returns exception
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: firewalld
Version: 8.1
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: 8.0
Assignee: Eric Garver
QA Contact: Tomas Dolezal
Levi
URL:
Whiteboard:
Depends On:
Blocks: 1738635 1755139
TreeView+ depends on / blocked
 
Reported: 2019-08-02 12:32 UTC by Sanne Raymaekers
Modified: 2020-04-28 16:51 UTC (History)
4 users (show)

Fixed In Version: firewalld-0.8.0-1.el8
Doc Type: Bug Fix
Doc Text:
.The DBus APIs in `org.fedoraproject.FirewallD1.config.service` work as expected Previously, the DBus API `getIncludes`, `setIncludes`, and `queryIncludes` functions in `org.fedoraproject.FirewallD1` returned an error message: `org.fedoraproject.FirewallD1.Exception: list index out of range` due to bad indexing. With this update, the DBus API `getIncludes`, `setIncludes`, and `queryIncludes` functions work as expected.
Clone Of:
Environment:
Last Closed: 2020-04-28 16:51:23 UTC
Type: Bug
Target Upstream Version:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2020:1836 0 None None None 2020-04-28 16:51:53 UTC

Description Sanne Raymaekers 2019-08-02 12:32:07 UTC 
Description of problem:

New org.fedoraproject.FirewallD1.config.service.getIncludes interface seems broken.


Version-Release number of selected component (if applicable):
0.7.0


How reproducible:

To any valid service's object path call: 

dbus-send --system --type=method_call --print-reply --dest=org.fedoraproject.FirewallD1 /org/fedoraproject/FirewallD1/config/service/19 org.fedoraproject.FirewallD1.config.service.getIncludes

Actual results:
Error org.fedoraproject.FirewallD1.Exception: list index out of range

Expected results:
List of includes
Comment 1 Eric Garver 2019-08-02 13:21:46 UTC 
(In reply to Sanne Raymaekers from comment #0)
> Description of problem:
> 
> New org.fedoraproject.FirewallD1.config.service.getIncludes interface seems
> broken.
> 
> 
> Version-Release number of selected component (if applicable):
> 0.7.0
> 
> 
> How reproducible:
> 
> To any valid service's object path call: 
> 
> dbus-send --system --type=method_call --print-reply
> --dest=org.fedoraproject.FirewallD1
> /org/fedoraproject/FirewallD1/config/service/19
> org.fedoraproject.FirewallD1.config.service.getIncludes
> 
> Actual results:
> Error org.fedoraproject.FirewallD1.Exception: list index out of range

Ugh. This individual API got broken when fixing bug 1721414. Alternatively you can use the new getSettings2() and update2() - they're dictionary based.
Comment 2 Eric Garver 2019-09-13 18:14:00 UTC 
Upstream:

33b61f1dc5ba ("test: dbus: service: coverage for *Includes")
81c51578eadd ("dbus: service: fix service includes individual APIs")
Comment 11 errata-xmlrpc 2020-04-28 16:51:23 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:1836
Note You need to log in before you can comment on or make changes to this bug.