Bug 1737053 - Image registry verify jobs are broken
Summary: Image registry verify jobs are broken
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Image Registry
Version: 4.2.0
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
: 4.2.0
Assignee: Corey Daley
QA Contact: XiuJuan Wang
Depends On:
TreeView+ depends on / blocked
Reported: 2019-08-02 13:06 UTC by Adam Kaplan
Modified: 2019-10-16 06:34 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2019-10-16 06:34:33 UTC
Target Upstream Version:

Attachments (Terms of Use)

System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2019:2922 0 None None None 2019-10-16 06:34:42 UTC

Description Adam Kaplan 2019-08-02 13:06:47 UTC
Description of problem: 
The `make verify` task for the image registry is broken - it doesn't work with golang 1.12 and uses tooling that is no longer maintained. Furthermore, this task is not run as a part of CI.

This is more critical as https://github.com/openshift/image-registry/pull/184 introduced static security analysis to our CI tooling.

`make verify` should be updated to

1. Work with golang 1.12
2. Replace deprecated tooling to align with the rest of the OpenShift org
3. Run with every PR

Comment 2 XiuJuan Wang 2019-08-12 11:46:26 UTC
@Corey https://github.com/openshift/cluster-image-registry-operator/pull/350 is for bug https://bugzilla.redhat.com/show_bug.cgi?id=1733902 , right?

So if this bug has fixed?

Comment 3 Corey Daley 2019-08-12 13:57:41 UTC
That pull should not be associated with this bugzilla, removing.

Comment 5 XiuJuan Wang 2019-08-14 03:41:58 UTC
@Corey How can I verify this bug? Could you give me some clews?

Comment 6 Corey Daley 2019-08-14 04:17:46 UTC
You could open a test pull request against the image registry and see that the verify job runs for the pull request.

Comment 7 XiuJuan Wang 2019-08-14 09:11:56 UTC
The image verify job has passed in master branch with https://github.com/openshift/image-registry/pull/190
Make this bug as verified

Comment 8 errata-xmlrpc 2019-10-16 06:34:33 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.