Bug 1737580 - Review Request: umoci - umoci modifies open container images
Summary: Review Request: umoci - umoci modifies open container images
Keywords:
Status: CLOSED DEFERRED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-08-05 17:19 UTC by jogas
Modified: 2021-01-04 15:51 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-08-17 14:03:01 UTC
Type: ---
Embargoed:
jogas: needinfo-


Attachments (Terms of Use)

Description jogas 2019-08-05 17:19:01 UTC
Spec URL: https://copr-be.cloud.fedoraproject.org/results/jogas/umoci/fedora-rawhide-x86_64/00995351-umoci/umoci.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/jogas/umoci/fedora-rawhide-x86_64/00995351-umoci/umoci-0.4.4-1.fc31.src.rpm

Description: simple package for umoci (umoci modifies Open Container images).
FAS: jogas
Sponsor: Orion Poplawski

rpmlint output:
$ rpmlint umoci
1 packages and 0 specfiles checked; 0 errors, 0 warnings

Note: Mock builds fail unless you enable internet access (e.g., 'rmpbuild_networking' = True). I'm not sure if this is normal or acceptable for go packages. Please advise.

Note: When you build umoci via `go build`, as the spec file does, it downloads from the following go packages:

github.com/opencontainers/go-digest v1.0.0-rc1
github.com/opencontainers/runtime-spec v1.0.0
github.com/mattn/go-colorable v0.0.9
github.com/mattn/go-isatty v0.0.3
github.com/hashicorp/errwrap v0.0.0-20180715044906-d6c0cd880357
github.com/blang/semver v3.5.1+incompatible
github.com/opencontainers/image-spec v1.0.0
github.com/vbatts/go-mtree v0.4.3
github.com/fatih/color v1.7.0
github.com/xeipuuv/gojsonschema v0.0.0-20180719132039-b84684d0e066
github.com/cyphar/filepath-securejoin v0.2.2
github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f
github.com/sirupsen/logrus v1.0.6
github.com/opencontainers/runtime-tools v0.7.0
github.com/klauspost/pgzip v0.0.0-20170402124221-0bf5dcad4ada
github.com/golang/protobuf v1.2.0
github.com/hashicorp/go-multierror v0.0.0-20180717150148-3d5d8f294aa0
github.com/pkg/errors v0.8.0
github.com/syndtr/gocapability v0.0.0-20180223013746-33e07d32887e
github.com/apex/log v1.1.0
github.com/klauspost/compress v1.4.0
github.com/urfave/cli v1.20.0
github.com/rootless-containers/proto v0.1.0
github.com/docker/go-units v0.3.3
github.com/klauspost/cpuid v0.0.0-20170728055534-ae7887de9fa5
github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415
github.com/klauspost/crc32 v0.0.0-20161016154125-cb6bfca970f6
github.com/mohae/deepcopy v0.0.0-20170603005431-491d3605edfb

It is unclear as how these packages should be referenced e.g., virtual provides, requires, buildrequires, etc. Please advise.

Comment 1 Elliott Sales de Andrade 2019-08-05 20:09:43 UTC
You cannot use the network when building packages. All those dependencies will need to be packaged as well (most of them already are, in fact).

You should also follow the guidelines for Go packages: https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/ Try using go2rpm to automate all this.

Comment 2 Robert-André Mauchin 🐧 2019-08-09 13:37:33 UTC
Use go2rpm github.com/openSUSE/umoci for F31 to use the new macros.

Use go2rpm -p1 github.com/openSUSE/umoci to use on F30/F29 with the old macros.

You'll need to package github.com/mohae/deepcopy and github.com/rootless-containers/proto the same way

Comment 3 Package Review 2020-08-09 00:45:29 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 4 jogas 2020-08-17 14:03:01 UTC
I no longer have a need to package umoci. Closing.


Note You need to log in before you can comment on or make changes to this bug.