Bug 1738290 - Review Request: libcamera - A library to support complex camera ISPs
Summary: Review Request: libcamera - A library to support complex camera ISPs
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: IoT
TreeView+ depends on / blocked
 
Reported: 2019-08-06 17:11 UTC by Peter Robinson
Modified: 2020-10-05 19:22 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: Bug


Attachments (Terms of Use)

Description Peter Robinson 2019-08-06 17:11:11 UTC
SPEC: https://pbrobinson.fedorapeople.org/libcamera.spec
SRPM: https://pbrobinson.fedorapeople.org/libcamera-0.0.0-0.1.36d6229.fc30.src.rpm

Description:
libcamera is a library that deals with heavy hardware image processing operations
of complex camera devices that are shared between the linux host all while allowing
offload of certain aspects to the control of complex camera hardware such as ISPs.

Hardware support includes USB UVC cameras, libv4l cameras as well as more complex
ISPs (Image Signal Processor).

FAS: pbrobinson

koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=36835411

Comment 1 Peter Robinson 2019-08-06 17:46:38 UTC
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=36835718

Comment 2 Xavier Bachelot 2019-08-07 16:35:11 UTC
Some notes from parsing the spec quickly :
- The SCM and snapshot date should be mentioned in the Release: tag.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/

- Even if you're packaging a snapshot, you can have a full URL in Source0.
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/

- I guess there's no versioned soname yet ?

Comment 3 Robert-André Mauchin 🐧 2019-08-09 14:29:45 UTC
%global commit          36d62298b20bec1f052fac04fd3011511cc29226
%global shortcommit     %(c=%{commit}; echo ${c:0:7})
%global snapshotdate    20190809

Name:    libcamera
Version: 0
Release: 0.1%{?commit:.%{snapshotdate}git%{shortcommit}}%{?dist}

 - Ask upstream to add soname versioning to their library. If they refuse, do it downstream: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_downstream_so_name_versioning

Comment 4 Peter Robinson 2019-08-10 08:36:13 UTC
>  - Ask upstream to add soname versioning to their library. If they refuse,
> do it downstream:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/
> #_downstream_so_name_versioning

I've spoken with upstream and they will be adding so name versioning closer to the first release, they don't feel it's ready for that yet and all the tools that currently use it are internal to the repo. Once they start adding support to things like gstreamer they will be versioning it.

Comment 5 Package Review 2020-08-10 00:45:24 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 6 Peter Robinson 2020-08-10 15:03:40 UTC
Still working with upstream, will look at a rebase shortly. It's the way the new Raspberry Pi camera is supported so we still need it.

Comment 7 Robert-André Mauchin 🐧 2020-08-26 14:47:49 UTC
NEEDINFO me when you're ready.

Comment 8 Dave Olsthoorn 2020-09-12 13:30:04 UTC
Since I was looking at libcamera for another project I rebased the spec file and made some other changes:
- Add %check, it passed locally, but somehow not on koji
- Splitting the existing package into muliple packages: separate docs, ipa modules and utilities
- Disabling LTO, it broke the tests in %check
- Adding some BuildRequires for new things: qcam, gstreamer plugin, ipa module signing and more
Feel free to ignore if you don't want the changes I made:

SPEC: https://daveo.fedorapeople.org/review/libcamera/0.0.0-0.2.6f09a61/libcamera.spec
SRPM: https://daveo.fedorapeople.org/review/libcamera/0.0.0-0.2.6f09a61/libcamera-0.0.0-0.2.6f09a61.fc34.src.rpm

FAS: daveo

koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=51300458

Comment 9 Robert-André Mauchin 🐧 2020-10-05 18:59:11 UTC
(In reply to Dave Olsthoorn from comment #8)
> Since I was looking at libcamera for another project I rebased the spec file
> and made some other changes:
> - Add %check, it passed locally, but somehow not on koji
> - Splitting the existing package into muliple packages: separate docs, ipa
> modules and utilities
> - Disabling LTO, it broke the tests in %check
> - Adding some BuildRequires for new things: qcam, gstreamer plugin, ipa
> module signing and more
> Feel free to ignore if you don't want the changes I made:
> 
> SPEC:
> https://daveo.fedorapeople.org/review/libcamera/0.0.0-0.2.6f09a61/libcamera.
> spec
> SRPM:
> https://daveo.fedorapeople.org/review/libcamera/0.0.0-0.2.6f09a61/libcamera-
> 0.0.0-0.2.6f09a61.fc34.src.rpm
> 
> FAS: daveo
> 
> koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=51300458

Youneed to work with PRobinson on this, I can't approved a package for someone who is not the reporter.

Comment 10 Peter Robinson 2020-10-05 19:22:56 UTC
I have this on my list for post F-33 GA to revisit.


Note You need to log in before you can comment on or make changes to this bug.