Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1738374

Summary:	[sriov]sriov-network-config-daemon pod become CrashLoopBackOff when set numVfs more than total num
Product:	OpenShift Container Platform	Reporter:	zhaozhanqi <zzhao>
Component:	Networking	Assignee:	Peng Liu <pliu>
Networking sub component:	openshift-sdn	QA Contact:	zhaozhanqi <zzhao>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	medium
Priority:	medium	CC:	aos-bugs, fpan, wsun
Version:	4.2.0
Target Milestone:	---
Target Release:	4.3.0
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-01-23 11:05:01 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description zhaozhanqi 2019-08-07 02:21:30 UTC

Description of problem:
When set the numVfs more than total num. After a while, the sriov-network-config-daemon become Crash

Version-Release number of selected component (if applicable):
quay.io/openshift-release-dev/ocp-v4.0-art-dev:v4.2.0-201908041300-ose-sriov-dp-admission-controller

quay.io/openshift-release-dev/ocp-v4.0-art-dev:v4.2.0-201908051019-ose-sriov-network-config-daemon

How reproducible:
always

Steps to Reproduce:
1. install sriov operator 
2. Add SriovNetworkNodePolicy and set numVfs more than total num
3. Check the sriov-network-config-daemon

Actual results:
3. sriov-network-config-daemon become crash


Expected results:

network-resources-injector can block this


Additional info:

Comment 1 Peng Liu 2019-08-08 02:31:09 UTC

The validation of user config data needs to happen during custom resource creation, which requires an admission controller for SriovNetworkNodePolicy API. Since it's a new feature, we plan to support this feature in 4.3.

Comment 2 Peng Liu 2019-11-06 09:41:59 UTC

Solved by this Jira story https://jira.coreos.com/browse/SDN-514

Comment 3 zhaozhanqi 2019-11-07 08:30:41 UTC

Verified this bug with new added webhook image

Comment 5 errata-xmlrpc 2020-01-23 11:05:01 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0062