Bug 1738396 - Review Request: perl-DBIx-Class-Candy - Sugar for your favorite ORM, DBIx::Class
Summary: Review Request: perl-DBIx-Class-Candy - Sugar for your favorite ORM, DBIx::Class
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-08-07 05:58 UTC by Emmanuel Seyman
Modified: 2019-08-12 09:05 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-08-12 09:05:22 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Emmanuel Seyman 2019-08-07 05:58:40 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-DBIx-Class-Candy/perl-DBIx-Class-Candy.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-DBIx-Class-Candy/perl-DBIx-Class-Candy-0.005003-1.fc30.src.rpm
Description:
DBIx::Class::Candy is a simple sugar layer for definition of DBIx::Class
results. Note that it may later be expanded to add sugar for more
DBIx::Class related things.

Fedora Account System Username: eseyman
Rpmlint Output: 1 packages and 1 specfiles checked; 0 errors, 0 warnings.

Comment 1 Jitka Plesnikova 2019-08-07 07:35:25 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires are ok
TODO: perl(Test::Pod) can be removed, because author tests are not executed.

$ rpm -qp --requires perl-DBIx-Class-Candy-0.005003-1.fc31.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Carp)
      1 perl(DBIx::Class::Candy::Exports)
      1 perl(experimental)
      1 perl(feature)
      1 perl(Lingua::EN::Inflect)
      1 perl(:MODULE_COMPAT_5.30.0)
      1 perl(MRO::Compat)
      1 perl(namespace::clean)
      1 perl(strict)
      1 perl(Sub::Exporter)
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-DBIx-Class-Candy-0.005003-1.fc31.noarch.rpm | sort | uniq -c
      1 perl(DBIx::Class::Candy) = 0.005003
      1 perl-DBIx-Class-Candy = 0.005003-1.fc31
      1 perl(DBIx::Class::Candy::Exports) = 0.005003
      1 perl(DBIx::Class::Candy::ResultSet) = 0.005003
Binary provides are Ok.

$ rpmlint ./perl-DBIx-Class-Candy.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Please consider fixing 'TODO' item.

Resolution: Approved

Comment 2 Emmanuel Seyman 2019-08-07 18:59:50 UTC
Thank you, Jikta. Repo requested.

Comment 3 Gwyn Ciesla 2019-08-07 19:46:38 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-DBIx-Class-Candy

Comment 4 Emmanuel Seyman 2019-08-12 09:05:22 UTC
Built for rawhide and released as an update for f30 and f29.


Note You need to log in before you can comment on or make changes to this bug.