Bug 1738398 - Review Request: perl-DBIx-Introspector - Detect what database you are connected to
Summary: Review Request: perl-DBIx-Introspector - Detect what database you are connect...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-08-07 06:00 UTC by Emmanuel Seyman
Modified: 2019-08-12 09:06 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-08-12 09:06:00 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Emmanuel Seyman 2019-08-07 06:00:44 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-DBIx-Introspector/perl-DBIx-Introspector.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-DBIx-Introspector/perl-DBIx-Introspector-0.001005-1.fc30.src.rpm
Description:
DBIx::Introspector is a module factored out of the DBIx::Class database
detection code. Most code that needs to detect which database it is
connected to assumes that there is a one-to-one mapping from database
drivers to database engines. Unfortunately reality is rarely that simple.
For instance, DBD::ODBC is typically used to connect to SQL Server, but
ODBC can be used to connect to PostgreSQL, MySQL, and Oracle. Additionally,
while ODBC is the most common way to connect to SQL Server, it is not the
only option, as DBD::ADO can also be used.

Fedora Account System Username: eseyman
Rpmlint Ouput: 1 packages and 1 specfiles checked; 0 errors, 0 warnings.

Comment 1 Jitka Plesnikova 2019-08-07 09:18:27 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires are ok
TODO: perl(Test::Pod) can be removed, because release tests are not run.

$ rpm -qp --requires perl-DBIx-Introspector-0.001005-1.fc31.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(DBIx::Introspector::Driver)
      1 perl(:MODULE_COMPAT_5.30.0)
      1 perl(Moo)

Binary requires have to be fixed

FIX: Please add perl(DBI::Const::GetInfoType) - lib/DBIx/Introspector/Driver.pm:126
FIX: Please filter requires perl(DBIx::Introspector::Driver) or add it to 
     provides. It is provided by this package, but it is hidden for generators.
     Otherwise installation of the package fails:
Problem: conflicting requests
  - nothing provides perl(DBIx::Introspector::Driver) needed by perl-DBIx-Introspector-0.001005-1.fc31.noarch

$ rpm -qp --provides perl-DBIx-Introspector-0.001005-1.fc31.noarch.rpm | sort | uniq -c
      1 perl(DBIx::Introspector) = 0.001005
      1 perl-DBIx-Introspector = 0.001005-1.fc31
Binary provides are Ok.

$ rpmlint ./perl-DBIx-Introspector*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Please correct all 'FIX' issues and consider fixing 'TODO' items and
provide new spec file.

Resolution:
Not approved

Comment 2 Emmanuel Seyman 2019-08-07 19:06:23 UTC
(In reply to Jitka Plesnikova from comment #1)
>
> TODO: perl(Test::Pod) can be removed, because release tests are not run.

Done.

> FIX: Please add perl(DBI::Const::GetInfoType) -
> lib/DBIx/Introspector/Driver.pm:126

Done.

> FIX: Please filter requires perl(DBIx::Introspector::Driver) or add it to 
>      provides. It is provided by this package, but it is hidden for
> generators.

I added a Provides to the spec file.

> Please correct all 'FIX' issues and consider fixing 'TODO' items and
> provide new spec file.

Spec URL: http://people.parinux.org/~seyman/fedora/perl-DBIx-Introspector/perl-DBIx-Introspector.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-DBIx-Introspector/perl-DBIx-Introspector-0.001005-2.fc30.src.rpm

Comment 3 Jitka Plesnikova 2019-08-08 06:24:41 UTC
The package looks good now and installation was successful. 

Approved

Comment 4 Emmanuel Seyman 2019-08-08 17:51:03 UTC
Thank you, Jikta. Repo requested.

Comment 5 Gwyn Ciesla 2019-08-09 12:42:23 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-DBIx-Introspector

Comment 6 Emmanuel Seyman 2019-08-12 09:06:00 UTC
Built for rawhide and released as an update for f30 and f29.


Note You need to log in before you can comment on or make changes to this bug.