Bug 1738945 - libewf depends on Python 2
Summary: libewf depends on Python 2
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: libewf
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nicolas Chauvet (kwizart)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F31_PY2REMOVAL
TreeView+ depends on / blocked
 
Reported: 2019-08-08 12:02 UTC by Lumír Balhar
Modified: 2019-10-29 10:51 UTC (History)
3 users (show)

Fixed In Version: libewf-20140608-15.fc32
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-10-29 10:51:38 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
python2 condition (1.70 KB, patch)
2019-10-17 11:26 UTC, Nicolas Chauvet (kwizart)
no flags Details | Diff

Description Lumír Balhar 2019-08-08 12:02:08 UTC
Python 2.7 will reach end-of-life in January 2020, over 9 years after it was released. This falls within the Fedora 31 lifetime.
Packages that depend on Python 2 are being switched to Python 3 or removed from Fedora: https://fedoraproject.org/wiki/Changes/F31_Mass_Python_2_Package_Removal#Information_on_Remaining_Packages
Python 2 will be retired in Fedora 32: https://fedoraproject.org/wiki/Changes/RetirePython2

To help planning, we'd like to know the plans for libewf's future. Specifically:


- What is the reason for the Python2 dependency? (Is it software written in Python, or does it just provide Python bindings, or use Python in the build system or test runner?) 

- What are the upstream/community plans/timelines regarding Python 3?

- What is the guidance for porting to Python 3? (Assuming that there is someone who generally knows how to port to Python 3, but doesn't know anything about the particular package, what are the next steps to take?)


This bug is filed semi-automatically, and might not have all the context specific to libewf.
If you need anything from us, or something is unclear, please mention it here.

Thank you.

Comment 1 Ben Cotton 2019-08-13 17:10:10 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to '31'.

Comment 2 Ben Cotton 2019-08-13 17:29:30 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to 31.

Comment 3 Lumír Balhar 2019-08-16 08:55:21 UTC
Please answer the above questions. If you don't, the package can be orphaned: https://fedoraproject.org/wiki/Changes/F31_Mass_Python_2_Package_Removal#Information_on_Remaining_Packages

If you need any information or help, or if you need some more time, please let us know.

Comment 4 Nicolas Chauvet (kwizart) 2019-08-19 15:50:32 UTC
(In reply to Lumír Balhar from comment #0)
...
> - What is the reason for the Python2 dependency? (Is it software written in
> Python, or does it just provide Python bindings, or use Python in the build
> system or test runner?) 
There is a libewf.so that relies on python2 in the ewftools sub-package.

> - What are the upstream/community plans/timelines regarding Python 3?
This version of libewf from 2014 is the last stable and describe the EWF format that is frozen.
There is an experimental version that isn't ready for distros that will have python3 support.
 
> - What is the guidance for porting to Python 3? (Assuming that there is
> someone who generally knows how to port to Python 3, but doesn't know
> anything about the particular package, what are the next steps to take?)
Wait for the next version. No schedule yet.

Comment 5 Lumír Balhar 2019-08-27 06:50:17 UTC
Thank you for the info. Rawhide might be a good place for an experimental version of the package so it gets more testers, but it's up to you.

The current plan is to remove packages with dependency on Python 2 from Fedora 32 in the middle of November 2019. If you want to keep your package in Fedora after that date and you cannot port it to Python 3 yet, you need to request a FESCo exception for the package and all its Python 2 dependencies (even transitive) [1]. If you don't want to maintain it anymore, and nothing in Fedora uses it, you can retire it or just remove the Python 2 part from it (subpackage, module, bindings, etc.).

If you're considering filing the exception request, let us know. We can help (for example, we can help find all the dependencies).

[1] https://fedoraproject.org/wiki/Changes/RetirePython2#FESCo_exceptions

Comment 6 Michal Ambroz 2019-10-17 01:39:47 UTC
working on removing the python2 subpackage for f31+ and epel8+

Comment 7 Michal Ambroz 2019-10-17 06:53:29 UTC
Petr Viktorin:
> For prioritization: Please deal with **libewf** first, specifically its "fuse-python" dependency which is unmaintained and will be removed from the distro soon (this week?) unless it finds a maintainer.
> We know next to nothing about fuse-python. What should happen with it? Who knows it and wants to maintain it in Fedora? Should we rescue it and maintain it for a few months, to give you more time?

I have got working version without python2.
I will get rid of both python2-fuse fuse-python2 in f31.
The main functionality of the ewftools is working without that, it is just python binding and the dependency is just for ad-hoc mounting of the images from python. 
Mounting from tools is using fuse library and fusermount binary tool. So that will remain working as well.

Python3 will come once the new upstream version is considered stable so we can bring python3 binding later once it is working, while still being able to maintain the packages for older fedora releases from single spec file. 

For older releases (<=f30 or <=rhel7) I propose that I will separate the python2-pyewf subpackage from ewftools so it is clear that this is just python binding and that the other tools are not depending on that.
Do you agree?

Comment 8 Nicolas Chauvet (kwizart) 2019-10-17 07:17:49 UTC
> I will get rid of both python2-fuse fuse-python2 in f31.
No need to break f31 only f32 is requested so far.

Comment 9 Nicolas Chauvet (kwizart) 2019-10-17 07:19:52 UTC
and I don't expect there is any need to propagate this python change to others releases. (not even rhel that will have this own python2 maintenance cycle).

Comment 10 Michal Ambroz 2019-10-17 10:14:52 UTC
(In reply to Nicolas Chauvet (kwizart) from comment #8)
> > I will get rid of both python2-fuse fuse-python2 in f31.
> No need to break f31 only f32 is requested so far.

- python2 will be orphaned during lifetime of f31 = 2020-01-01 so it was actually requested 
- the python2 binding is not essential to how the tool is used and my 
- nobody claimed the needed fuse-python package dependency - will you take it Nicolas? Or do you plan to patch the libewf to change it to python-fuse and sync with the owner to build also python2 package?

> and I don't expect there is any need to propagate this python change to others releases. (not even rhel that will have this own python2 maintenance cycle).
- python2 module is now bundled to ewftools subpackage, but it is not used by that tools so the bundling is not needed
- current naming is not compliant with the nowdays python packaging guidelines
- separating it to python2-pyewf would make it symetrical and more understandable with future python3-pyewf subpackage
- for people it would be possible to rerun the build on the same fedora release using "--with python2" to build/install the extra package of python2-pyewf without risking that next fedora update to ewftools will delete that

Here is koji build https://koji.fedoraproject.org/koji/taskinfo?taskID=38342137
SPEC: https://rebus.fedorapeople.org/SPECS/libewf.spec
SRPM: https://rebus.fedorapeople.org/SRPMS/libewf-20140608-15.fc32.src.rpm

Comment 11 Nicolas Chauvet (kwizart) 2019-10-17 11:21:43 UTC
There is no retirement concept on released branched, so this change is spurious.
What is requested is to drop the python2 module and is mandatory only for f32+
There is no point to drop the current expectation that ewftools has the needed interfaces python2.

Also a diff version is due for reviewing against existing git module, please submit a patch


Will show a way less intrusive change...

Comment 12 Nicolas Chauvet (kwizart) 2019-10-17 11:26:04 UTC
Created attachment 1626772 [details]
python2 condition

Comment 13 Michal Ambroz 2019-10-17 13:15:38 UTC
Returning ticket back to you Nicolas sorry. 
I was summoned by Petr Viktorin  to work on this package (as a person with commit rights) as it seemed you as admin of the package are unresponsive.
As you already have a way forward to keep the package in Fedora f31 it doesn't make sense us to duplicate the efforts. You are the owner and I respect your solution.

Best regards
Michal Ambroz

Comment 14 Petr Viktorin (pviktori) 2019-10-29 10:51:38 UTC
Thank you for the minimal fix, Nicolas!


Note You need to log in before you can comment on or make changes to this bug.