Spec Name or Url: http://rpm.frields.org/extras-testing/xmlstarlet/xmlstarlet.spec SRPM Name or Url: http://rpm.frields.org/extras-testing/xmlstarlet/xmlstarlet-1.0.2-1.1.src.rpm Description: XMLStarlet is a set of command line utilities which can be used to transform, query, validate, and edit XML documents and files using simple set of shell commands in similar way it is done for plain text files using UNIX grep, sed, awk, diff, patch, join, etc commands. In July 2005, Ignacio Vazquez-Abrams submitted this on-list for review, and withdrew it because there were numerous things that needed patching. Thanks to Ignacio and Tommy Reynolds, I think this software can be offered again for FE review and inclusion. Ignacio has graciously agreed to hand this off to me for shepherding. This utility is intended to form part of the Fedora Documentation Project toolchain, since we deal primarily in DocBook XML, so we would appreciate a reviewer's attention. Thank you!
*** Bug 173923 has been marked as a duplicate of this bug. ***
In general I think inclusion of xmlstarlet makes sense, Daniel
Oops, there was a small snafu between Tommy and me, so please disregard the earlier URLs. Here are the corrected versions: Spec: http://rpm.frields.org/extras-testing/xmlstarlet/xmlstarlet.spec SRPM: http://rpm.frields.org/extras-testing/xmlstarlet/xmlstarlet-1.0.1-1.1.src.rpm
Additional fixes to make the command name in the included docs consistent. New versions: Spec: http://rpm.frields.org/extras-testing/xmlstarlet/xmlstarlet.spec SRPM: http://rpm.frields.org/extras-testing/xmlstarlet/xmlstarlet-1.0.1-1.2.src.rpm
I'm getting a 403 on the spec file.
- Source0 should be http://dl.sourceforge.net/xmlstar/xmlstarlet-%{version}.tar.gz, replacing %{name} in there is optional - Files in %{_mandir} are already marked %doc ! Releases with subreleases (X.Y) might cause problems with the disttag + Upstream source (from proper location) matches + Correct permissions + Builds cleanly in mock + No rpmlint warnings or errors
Handled all your comments, Ignacio. Sorry about the spec file mode -- I fixed that as well. I was only using the subreleases for my private packages but I've gone ahead and removed them for this release, now 2%{?dist}. They are available here: Spec: http://rpm.frields.org/extras-testing/xmlstarlet/xmlstarlet.spec SRPM: http://rpm.frields.org/extras-testing/xmlstarlet/xmlstarlet-1.0.1-2.src.rpm Thanks for your prompt review!
Ignacio, any chance to look at the revision?
Sorry, got distracted for a bit. APPROVED, unless someone else can think of a reason to veto it.
Paul, would you mind maintaining an EL5 branch for xmlstarlet ? I can offer to maintain the branch myself if you don't want to. Regards, Xavier
I don't mind; the code hasn't changed in a long time and appears to work well everywhere I've used it. (IIRC there's a test suite that runs in the build process.)
Package Change Request ====================== Package Name: xmlstarlet New Branches: EL-5 Owners: pfrields
cvs done.
Thank you Kevin -- tagged, built, and requested for EPEL testing. Xavier, after the next push for EPEL testing you should find the package there. Please take the time to give it a +1 karma in bodhi if everything works for you: https://admin.fedoraproject.org/updates/xmlstarlet