Created attachment 1602053 [details] Initial run tabs Description of problem: When I have a VM with snapshot and cloud-init is not set, cloning VM from snapshot sets to use cloud-init. Version-Release number of selected component (if applicable): ovirt-engine-4.3.6-0.1.el7.noarch How reproducible: always Steps to Reproduce: 1. create new VM, cloud-init in Initial run is not checked 2. create snapshot on that VM 3. clone VM from the snapshot Actual results: clound-init is checked, see attachment Expected results: clound-init is not checked
One can easily fix this issue by initializing the VmInit control properly within the VmSnapshotListModel.java's cloneVM function. The larger issue is that when the original VM is actually set, we are not setting the other Vm Init controls as per the original VM and we should do that as well. There are I assume other fields that we are not inheriting properly from the original VM when cloning a snap shot which would require further testing and investigation. The Snap Shot's information is Stored within the snapshots DB Table. A design question would be if we should add the VM Init fields (as wel as any other missing data) to this DB which may cause some performance issues elsewhere, or attempt to fetch the original VM within the cloneVM function and access the original values directly (although the problem here is if the original was changed, one should clone from the snapshot which is by definition what a snap shot is). Of cause saving more data to the snapshots DB Table seems to be the most sense, but please advise accordingly.
(In reply to Steven Rosenberg from comment #1) > One can easily fix this issue by initializing the VmInit control properly > within the VmSnapshotListModel.java's cloneVM function. The larger issue is > that when the original VM is actually set, we are not setting the other Vm > Init controls as per the original VM and we should do that as well. There > are I assume other fields that we are not inheriting properly from the > original VM when cloning a snap shot which would require further testing and > investigation. > > The Snap Shot's information is Stored within the snapshots DB Table. A > design question would be if we should add the VM Init fields (as wel as any > other missing data) to this DB which may cause some performance issues > elsewhere, or attempt to fetch the original VM within the cloneVM function > and access the original values directly (although the problem here is if the > original was changed, one should clone from the snapshot which is by > definition what a snap shot is). > > Of cause saving more data to the snapshots DB Table seems to be the most > sense, but please advise accordingly. I believe you are right here. Please check with developers in that area and test with QE if and what perfomance impacts this might have. I don't expect any serious, but we should be sure. Thanks! Martin
Verified with: - RHV 4.4.0-0.32.master.el8ev Verification steps: 2. Create a VM and make sure the cloud-init is unchecked 3. Create a snapshot 4. Clone a new VM from the snapshot and make sure the cloud-init is unchecked on the new cloned VM Result: - The cloud-init is not checked on the new VM cloned from the snapshot.
This bugzilla is included in oVirt 4.4.1 release, published on July 8th 2020. Since the problem described in this bug report should be resolved in oVirt 4.4.1 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report.