Spec URL: https://huzaifas.fedorapeople.org/python-SimpleSOAP.spec SRPM URL: https://huzaifas.fedorapeople.org/python-SimpleSOAP-1.16.2-1.fc30.src.rpm Description: Python simple and lightweight SOAP library for client and server webservices interfaces, aimed to be as small and easy as possible, supporting most common functionality. Fedora Account System huzaifas
New spec/srpm to mitigate rpmlint warnings: SPEC: https://huzaifas.fedorapeople.org/python-SimpleSOAP.spec SRPM: https://huzaifas.fedorapeople.org/python-SimpleSOAP-1.16.2-2.fc30.src.rpm
1) License tag need to be "LGPLv3+". Whenever license text says "or (at your option) any later version" use "+". 2) Package name should be python-pysimplesoap because we need to use the name that we import library. Here we will be using "import pysimplesoap" so package name is python-<modulename> that is python-pysimplesoap. 3) License text is not present and I can see upstream also have tests. In this case I generally recommends to use upstream tarball as a source URL but upstream has not released a new tarball so you can ask upstream to do so OR Source1: https://raw.githubusercontent.com/pysimplesoap/pysimplesoap/master/license.txt upload this file with upstream tarball and add in %prep cp -p %{SOURCE1} . then in %files section %doc license.txt 4) Instead of what has been packaged in above SRPM, change it to %prep %autosetup -n %{pypi_name}-%{version} for lib in pysimplesoap/*.py; do sed -e '1{\@^#! /usr/bin/env python@d}' -e '1{\@^#!/usr/bin/env python@d}' \ -e '1{\@^#!/usr/bin/python@d}' $lib > $lib.new && touch -r $lib $lib.new && mv $lib.new $lib done %build %py3_build %install %py3_install Update the spec and submit new update for further review.
Add changed have been incorporated. SPEC: https://huzaifas.fedorapeople.org/python-pysimplesoap.spec SRPM: https://huzaifas.fedorapeople.org/python-pysimplesoap.spec Also: [huzaifas@babylon SPECS]$ rpmlint /home/huzaifas/NotBackedUp/rpm/RPMS/noarch/python3-pysimplesoap-1.16.2-3.fc30.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
New SPEC: https://huzaifas.fedorapeople.org/python-pysimplesoap.spec New SPRM: https://huzaifas.fedorapeople.org/python-pysimplesoap-1.16.2-3.fc30.src.rpm Again: [huzaifas@babylon SPECS]$ rpmlint /home/huzaifas/NotBackedUp/rpm/RPMS/noarch/python3-pysimplesoap-1.16.2-3.fc30.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file license.txt is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text ==> Sorry, I missed to suggest to use %license tag. So fix this by changing line %doc license.txt to %license license.txt ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GNU Lesser General Public License (v3 or later)", "Python Software Foundation License version 2". 3 files have unknown license. Detailed output of licensecheck in /home/test/1739784-python- pysimplesoap/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [-]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-pysimplesoap-1.16.2-3.fc31.noarch.rpm python-pysimplesoap-1.16.2-3.fc31.src.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). python3-pysimplesoap.noarch: W: invalid-url URL: https://github.com/pysimplesoap/pysimplesoap <urlopen error [Errno -2] Name or service not known> 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Source checksums ---------------- https://raw.githubusercontent.com/pysimplesoap/pysimplesoap/master/license.txt : CHECKSUM(SHA256) this package : 7356e6cda1d7f2e62663e6749aeeb1a1b8e33553f96d6517bad7904bc3423e5a CHECKSUM(SHA256) upstream package : 7356e6cda1d7f2e62663e6749aeeb1a1b8e33553f96d6517bad7904bc3423e5a https://files.pythonhosted.org/packages/source/P/PySimpleSOAP/PySimpleSOAP-1.16.2.tar.gz : CHECKSUM(SHA256) this package : b1bbf4d0d0adff9b652197d61aa1b76731ad618849e27d28fe5cb250916d67e1 CHECKSUM(SHA256) upstream package : b1bbf4d0d0adff9b652197d61aa1b76731ad618849e27d28fe5cb250916d67e1 Requires -------- python3-pysimplesoap (rpmlib, GLIBC filtered): python(abi) Provides -------- python3-pysimplesoap: python-PySimpleSOAP python3-pysimplesoap python3.7dist(pysimplesoap) python3dist(pysimplesoap) Generated by fedora-review 0.7.2 (65d36bb) last change: 2019-04-09 Command line :/usr/bin/fedora-review -b 1739784 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Python, Generic Disabled plugins: SugarActivity, fonts, Haskell, R, Perl, PHP, C/C++, Ocaml, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH So, don't forget to change %doc to %license and then import this package in Fedora. APPROVED
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pysimplesoap
Closing this package review bug.