Spec URL: https://in.waw.pl/~zbyszek/fedora/python-fiat.spec SRPM URL: https://in.waw.pl/~zbyszek/fedora/python-fiat-2019.1.0-1.fc31.src.rpm Description: The FInite element Automatic Tabulator FIAT supports generation of arbitrary order instances of the Lagrange elements on lines, triangles, and tetrahedra. It is also capable of generating arbitrary order instances of Jacobi-type quadrature rules on the same element shapes. Further, H(div) and H(curl) conforming finite element spaces such as the families of Raviart-Thomas, Brezzi-Douglas-Marini and Nedelec are supported on triangles and tetrahedra. Upcoming versions will also support Hermite and nonconforming elements. FIAT is part of the FEniCS Project. Fedora Account System Username: zbyszek
- You need to add the Python provide macro: %package -n python3-fiat Summary: %summary %{?python_provide:%python_provide python3-fiat} %description -n python3-fiat %_description - Build error: DEBUG util.py:600: Error: DEBUG util.py:600: Problem: package python3-sympy-1.4-2.fc31.noarch requires python(abi) = 3.7, but none of the providers can be installed DEBUG util.py:600: - package python3-devel-3.8.0~b3-4.fc32.x86_64 conflicts with python3 < 3.8.0~b3-4.fc32 provided by python3-3.7.4-5.fc31.i686 DEBUG util.py:600: - package python3-devel-3.8.0~b3-4.fc32.x86_64 conflicts with python3 < 3.8.0~b3-4.fc32 provided by python3-3.7.4-5.fc31.x86_64 DEBUG util.py:600: - cannot install the best candidate for the job DEBUG util.py:602: (try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages) python3-sympy needs python-theanos which is FTBFS.
Okay I fixed Theanos and Sympy. Build still fails, the first patch is not applied: + /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch The text leading up to this was: -------------------------- |diff --git a/.travis.yml b/.travis.yml |index 9d326af..5dba4cb 100644 |--- a/.travis.yml |+++ b/.travis.yml -------------------------- File to patch: Skip this patch? [y] 1 out of 1 hunk ignored RPM build errors: error: Bad exit status from /var/tmp/rpm-tmp.ftOfvv (%prep) Bad exit status from /var/tmp/rpm-tmp.ftOfvv (%prep) There's no .travis.yml in the archive so it can't be applied.
- There's a lot of mix of spaces and tabs: python-fiat.src:11: W: mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line 1) Please unify under one standard. Assuming you fix Patch0001 to remove the .travis.yml bits, the package is approved. Please also fix the aforementioned issue. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-fiat-2019.1.0-1.fc32.noarch.rpm python-fiat-2019.1.0-1.fc32.src.rpm python3-fiat.noarch: W: spelling-error Summary(en_US) tetrahedra -> tetrahedral, tetrahedron python3-fiat.noarch: E: summary-too-long C Generator of arbitrary order instances of Lagrange elements on lines, triangles, and tetrahedra python3-fiat.noarch: W: spelling-error %description -l en_US tetrahedra -> tetrahedral, tetrahedron python-fiat.src: W: spelling-error Summary(en_US) tetrahedra -> tetrahedral, tetrahedron python-fiat.src: E: summary-too-long C Generator of arbitrary order instances of Lagrange elements on lines, triangles, and tetrahedra python-fiat.src: W: spelling-error %description -l en_US tetrahedra -> tetrahedral, tetrahedron python-fiat.src:11: W: mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line 1) python-fiat.src: W: file-size-mismatch patch0001.patch = 4218, https://bitbucket.org/fenics-project/fiat/commits/852a15f1a21e360cde3bc8b53693dc933712806e/raw#/patch0001.patch = 4482 2 packages and 0 specfiles checked; 2 errors, 6 warnings.
Thanks. Somehow the srpm had a patch from before I edited it to make it apply. Should be fixed now.
Duh, I screwed up badly. Package exists already. I'll submit my version as a PR.
https://src.fedoraproject.org/rpms/python-fiat/pull-request/1