RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1740383 - the nvdimm-security.conf dracut module needs spaces in the add_drivers value
Summary: the nvdimm-security.conf dracut module needs spaces in the add_drivers value
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: ndctl
Version: 7.7
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Jeff Moyer
QA Contact: Zhang Yi
URL:
Whiteboard:
: 1782690 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-08-12 19:22 UTC by Jeff Moyer
Modified: 2023-09-07 20:23 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-03-31 19:53:27 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2020:1076 0 None None None 2020-03-31 19:53:34 UTC

Description Jeff Moyer 2019-08-12 19:22:26 UTC
Description of problem:
dracut modules need to add spaces before and after the kernel modules listed in an add_drivers directive.  If not, there's a chance that multiple modules will have their driver names mashed together, and the kernel drivers won't be added to the initial ramdisk.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
https://github.com/pmem/ndctl/issues/103

Comment 4 Zhang Yi 2019-11-22 06:56:21 UTC
After setup-passphrase/freeze-security operation, we need include the updated keys to initramfs 
#dracut --include /etc/ndctl/keys /etc/ndctl/keys --install "ndctl keyctl" -f

Pass ndctl basic security operations: setup-passphrase/update-passphrase/remove-passphrase/sanitize-dimm/freeze-security on intel AEP, move to VERIFIED.

[root@intel-purley-aep-02 ~]# rpm -qa ndctl
 ndctl-65-5.el7.x86_64
u[root@intel-purley-aep-02 ~]#  uname  -r
3.10.0-1111.el7.x86_64
[root@intel-purley-aep-02 ~]# cat /etc/dracut.conf.d/nvdimm-security.conf 
# Make sure libnvdimm is loaded and ndctl is available in the initramfs
install_items+="/bin/ndctl"
add_drivers+=" libnvdimm "

Comment 5 Jeff Moyer 2019-12-12 16:09:31 UTC
*** Bug 1782690 has been marked as a duplicate of this bug. ***

Comment 6 Sujith 2020-01-08 10:45:11 UTC
(In reply to Zhang Yi from comment #4)
> After setup-passphrase/freeze-security operation, we need include the
> updated keys to initramfs 
> #dracut --include /etc/ndctl/keys /etc/ndctl/keys --install "ndctl keyctl" -f

Hi Yi,
Sorry to bring up an old matter, but is there any upstream or RH kbase which calls out that initramfs has to be re-created through dracut with these params while working on security operations of ndctl?

Comment 7 Zhang Yi 2020-01-08 11:17:33 UTC
Hi Sujith

I'm not sure about it, seems only [1] described the unlock operation and mentioned initramfs.

@Jeff, could you help confirm it


[1]
https://github.com/pmem/ndctl/blob/master/Documentation/ndctl/intel-nvdimm-security.txt
=== UNLOCK

Unlock is performed by the kernel, however a preparation step must happen
before the unlock DSM can be issued by the kernel. It is expected that
from the initramfs, a setup command (ndctl 'load-keys') is executed before
the libnvdimm module is loaded by modprobe. This command will inject the
'kek' and the encrypted passphrases into the kernel's user keyring. During
the 'probe' of the libnvdimm driver, it will:

. Check the security state of the device and see if the DIMM is locked
. Request the associated encrypted passphrase from the kernel's user key ring
. Use the 'kek' to decrypt the passphrase
. Create the unlock DSM, copy the decrypted payload into the DSM
. Issue the DSM to unlock the DIMM

Thanks
Yi

Comment 9 Jeff Moyer 2020-01-14 19:05:02 UTC
(In reply to Sujith from comment #6)
> (In reply to Zhang Yi from comment #4)
> > After setup-passphrase/freeze-security operation, we need include the
> > updated keys to initramfs 
> > #dracut --include /etc/ndctl/keys /etc/ndctl/keys --install "ndctl keyctl" -f
> 
> Hi Yi,
> Sorry to bring up an old matter, but is there any upstream or RH kbase which
> calls out that initramfs has to be re-created through dracut with these
> params while working on security operations of ndctl?

Not that I know of.

Comment 11 errata-xmlrpc 2020-03-31 19:53:27 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:1076


Note You need to log in before you can comment on or make changes to this bug.