Red Hat Bugzilla – Bug 174060
at (and others) fail to compile with WITH_SELINUX=0
Last modified: 2007-11-30 17:11:17 EST
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (compatible; MSIE 6.0; Windows; U; AIIEEEE!; Win98; Windows 98; en-US; Gecko masquerading as IE; should it matter?; rv:1.8b) Gecko/20050217
Description of problem:
When compiling at (and other programs with autoconf) with SELINUX disabled a lot of the patches fail because they expect to see WITH_SELINUX macros in text which has been diff'ed.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1.rpmbuild -v -ba --define "WITH_SELINUX 0" at.spec
Actual Results: 2 out of 2 hunks FAILED
Expected Results: Compile should work!
The problem is if you have a patch that conditionally adds code to configure.in then you have patches that patch code which may or may not have WITH_SELINUX and SELINUXLIB macros in them then you break a lot of patches.
So when, for example, Makefile.in is generated and it has no $(SELINUXLIB) macro in it (instead of just an empty one) then subsequent patches are going to fail.
Created attachment 121434 [details]
Patch to fix at.spec SELINUX conditional build
You have to ensure that the "at-selinux.patch" (Patch22) is applied even if
WITH_SELINUX is 0 otherwise subsequent patches will fail.
at does not need to compile without SELinux support - hence, this is NOTABUG.
A new enhanced version of at that I am working on will move SELinux support to
a separate source file, which should make compilation without SELinux much easier.