Bug 1741122 - Comparing Instances/Hosts displayed in a nested list does not work
Summary: Comparing Instances/Hosts displayed in a nested list does not work
Status: POST
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.11.0
Hardware: Unspecified
OS: Unspecified
Target Milestone: GA
: 5.11.z
Assignee: Hilda Stastna
QA Contact: PJ Richardson
Red Hat CloudForms Documentation
Depends On:
TreeView+ depends on / blocked
Reported: 2019-08-14 10:17 UTC by Hilda Stastna
Modified: 2021-05-06 03:12 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed:
Category: Bug
Cloudforms Team: CFME Core
Target Upstream Version:

Attachments (Terms of Use)

Description Hilda Stastna 2019-08-14 10:17:15 UTC
Description of problem:
It is not possible to compare Instances/Hosts displayed in a nested list.

Version-Release number of selected component (if applicable):
5.10, 5.11.0

How reproducible:

Steps to Reproduce:
1. Go to Networks > Networks and click on some Cloud Network
2. In Relationships, click on Instances
3. Select at least two Instances (checkboxes)
4. Configuration > Compare Selected items

Actual results:
Nothing happens in the UI. Log:

[----] I, [2019-08-14T12:16:09.469249 #31155:2b04d46530e8]  INFO -- : Started POST "/cloud_network/button/1?pressed=instance_compare" for at 2019-08-14 12:16:09 +0200
[----] I, [2019-08-14T12:16:09.543525 #31155:2b04d46530e8]  INFO -- : Processing by CloudNetworkController#button as JS
[----] I, [2019-08-14T12:16:09.543715 #31155:2b04d46530e8]  INFO -- :   Parameters: {"miq_grid_checks"=>"2178,2186", "pressed"=>"instance_compare", "id"=>"1"}
[----] I, [2019-08-14T12:16:09.596174 #31155:2b04d46530e8]  INFO -- : No template found for CloudNetworkController#button, rendering head :no_content
Session:	 Hash of Size 7857, Elements 28
[----] I, [2019-08-14T12:16:09.597213 #31155:2b04d46530e8]  INFO -- : Completed 204 No Content in 53ms (ActiveRecord: 1.7ms)

Expected results:
Compare screen for selected items with accordion should be displayed.

Additional info:
Where compare method is missing:
a) comparing hosts displayed as a nested list
- this will be reproducible after adding routes
(different BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1733120)
b) Networks > Networks > some network > Instances > compare
c) Networks > Subnets > some subnet > Instances > compare
d) Networks > Network Routers > some router > Instances > compare
e) Networks > Security Groups > some group > Instances > compare

It looks like method call for comparing items in appropriate controllers is missing.

Comment 2 Hilda Stastna 2019-08-14 13:27:09 UTC
Note that missing Cancel button to cancel Compare action will be added via another BZ:

Comment 4 CFME Bot 2019-09-05 15:21:27 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:

commit 467d061126749be53fa06b01372034b970385089
Author:     Hilda Stastna <hstastna@redhat.com>
AuthorDate: Fri Aug 16 05:28:27 2019 -0400
Commit:     Hilda Stastna <hstastna@redhat.com>
CommitDate: Fri Aug 16 05:28:27 2019 -0400

    Allow comparing Hosts displayed as a nested list

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1741122

 app/controllers/application_controller/ci_processing.rb | 2 -
 app/controllers/storage_controller.rb | 32 +-
 spec/controllers/storage_controller_spec.rb | 16 +-
 3 files changed, 35 insertions(+), 15 deletions(-)

Note You need to log in before you can comment on or make changes to this bug.