Bug 1741132
| Summary: | Switch to GiB/TiB rather than Gi/Ti | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Tomas Jelinek <tjelinek> |
| Component: | Management Console | Assignee: | Andy Braren <abraren> |
| Status: | CLOSED ERRATA | QA Contact: | Yadan Pei <yapei> |
| Severity: | low | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 4.2.0 | CC: | aos-bugs, ebondare, hasha, jokerman, spadgett, wking |
| Target Milestone: | --- | ||
| Target Release: | 4.4.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-05-04 11:13:08 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Tomas Jelinek
2019-08-14 10:56:42 UTC
Lots of conflicts on the PR per GitHub, and PR targets master. I'm going to punt this to 4.3.0. I checked dashboad, pv, pvc, limit range pages, they all updated to GiB/TiB But the 'Max' in table of Resource Quota Details page did not change. did it changed by this pr? I'll assign back firstly. *** Bug 1772569 has been marked as a duplicate of this bug. *** Goto Storage->pvc page->create pvc, Switch GiB/TiB/MiB in size dropdown, it will change to Gi/Ti/Mi toggle text I believe seeing Mi/Gi in the Max column of a Resource Quota Details page is okay, because that table directly reflects what's in the YAML (each row is a field, each Max has the value without any spaces). The behavior in the Create PVC form is odd though and I'm not sure how to fix it. I notice if you click the value in the dropdown again, it'll switch to GiB correctly. zherman we did the reverse of this change a year ago in https://github.com/openshift/console/pull/1228, any idea how to fix this? Yeah, so things are pretty messed up on that page currently. Last year I was asked to changed it, so it is funny we have now changed it back. I think you need to make both the value and key values have 'B', so const dropdownUnits = {
MiB: 'MiB',
GiB: 'GiB',
TiB: 'TiB',
};
Also, you need to change the default value set in the useState:
const [requestSizeUnit, setRequestSizeUnit] = React.useState('GiB');
I think that should fix it but I did not test that change.
@abraren - see my note above @zherman I think followed your note correctly in this PR, which does fix the dropdown behavior, but introduces a validation issue :( https://github.com/openshift/console/pull/3942 Goto Storage->pvc page->create pvc, Switch GiB/TiB/MiB in size dropdown, it will be GiB/TiB/MiB toggle text 4.4.0-0.nightly-2020-02-19-041512 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:0581 |