When in Overview->Optimization->Top CPU Consumers (Weekly) There is no breadcrumb back if you go into the report section. The only breadcrumb is for the optimization section. This should behave like the rest of the section such as Overview->Optimization->Offline VMs with Snapshot->Offline VMs with Snapshots
Stephen, in the future, please provide a screenshot, proper steps to reproduce, actual results and expected results - it was almost impossible to decipher what you meant. From what I can tell: 1. Go to Overview > Optimization 2. make sure at least 1 report exists for "Top CPU Consumers (weekly)" 3. open "Top CPU Consumers (weekly)" 4. open a report result in the list or Top CPU Consumers weekly report results Expected: the breadcrumb will say Overview > Optimization [link] > Top CPU Consumers (weekly) [link] > Top CPU Consumers (weekly) [no link] Actual: the breadcrumb says Overview > Optimization [link] > Top CPU Consumers (weekly) [no link] Additional information: Only that one report kind ("Top CPU Consumers (weekly)") is affected, because the title of the saved report is exactly the same as the title of the report definition
https://github.com/ManageIQ/manageiq-ui-classic/pull/6041
New commits detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/e88600782bcefd86859731f2d1bfc00e98ac4069 commit e88600782bcefd86859731f2d1bfc00e98ac4069 Author: Martin Hradil <mhradil> AuthorDate: Thu Aug 15 10:30:03 2019 -0400 Commit: Martin Hradil <mhradil> CommitDate: Thu Aug 15 10:30:03 2019 -0400 Optimization - spec for breadcrumbs when report.name and saved.name are identical breadcrumbs deduplicate breadcrumbs with identical titles, but for Optimization, the "saved reports under report" can have the same title as the "saved report detail" screen, because the names of the saved reports are generated from the name of the report definition. Adding a (failing) spec to make sure these don't get deduplicated in those conditions. https://bugzilla.redhat.com/show_bug.cgi?id=1741203 spec/controllers/optimization_controller_spec.rb | 23 + 1 file changed, 23 insertions(+) https://github.com/ManageIQ/manageiq-ui-classic/commit/6df40b54854ab0664c104752b97cd3490f47c2b5 commit 6df40b54854ab0664c104752b97cd3490f47c2b5 Author: Martin Hradil <mhradil> AuthorDate: Thu Aug 15 11:24:47 2019 -0400 Commit: Martin Hradil <mhradil> CommitDate: Thu Aug 15 11:24:47 2019 -0400 BreadcrumbsMixin - add a no_magic option (defaults to false) providing :no_magic => true in breadcrumb definition will just pass on the breadcrumbs from the controller the legacy controller magic is necessary for old code, but really problematic for any new code trying to render specific breadcrumbs, so we need a way of switching it off https://bugzilla.redhat.com/show_bug.cgi?id=1741203 app/controllers/mixins/breadcrumbs_mixin.rb | 3 + 1 file changed, 3 insertions(+) https://github.com/ManageIQ/manageiq-ui-classic/commit/ae5c79cda76888bc0590f6b74d1dd4baccb763a4 commit ae5c79cda76888bc0590f6b74d1dd4baccb763a4 Author: Martin Hradil <mhradil> AuthorDate: Thu Aug 15 11:25:58 2019 -0400 Commit: Martin Hradil <mhradil> CommitDate: Thu Aug 15 11:25:58 2019 -0400 Optimization breadcrumbs - use no_magic to fix breadcrumbs Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1741203 app/controllers/optimization_controller.rb | 2 + 1 file changed, 2 insertions(+) https://github.com/ManageIQ/manageiq-ui-classic/commit/6a28cedae93028f02819ffd3b9e42c9104cfc331 commit 6a28cedae93028f02819ffd3b9e42c9104cfc331 Author: Martin Hradil <mhradil> AuthorDate: Fri Aug 16 09:10:11 2019 -0400 Commit: Martin Hradil <mhradil> CommitDate: Fri Aug 16 09:10:11 2019 -0400 OptimizationController - override data_for_breadcrumbs thus removing the need for a :no_magic option Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1741203 app/controllers/mixins/breadcrumbs_mixin.rb | 3 - app/controllers/optimization_controller.rb | 8 +- 2 files changed, 6 insertions(+), 5 deletions(-)
New commit detected on ManageIQ/manageiq-ui-classic/ivanchuk: https://github.com/ManageIQ/manageiq-ui-classic/commit/e2aaab3607c03e21bdb65939aa1f34b993baac86 commit e2aaab3607c03e21bdb65939aa1f34b993baac86 Author: Milan Zázrivec <mzazrivec> AuthorDate: Mon Aug 19 09:04:31 2019 +0000 Commit: Milan Zázrivec <mzazrivec> CommitDate: Mon Aug 19 09:04:31 2019 +0000 Merge pull request #6041 from himdel/bz1741203-breadcrumb.dup Optimization - don't deduplicate breadcrumbs when report definition and saved report have the same name (cherry picked from commit 0ea8a49b3c530ef59e7df2bdf5b7abe1aeba7c3c) https://bugzilla.redhat.com/show_bug.cgi?id=1741203 app/controllers/optimization_controller.rb | 8 +- spec/controllers/optimization_controller_spec.rb | 23 + 2 files changed, 30 insertions(+), 1 deletion(-)
FIXED. Verified on 5.11.5.1.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:2020