Bug 1741807 - Failed to hot-plug vcpus
Summary: Failed to hot-plug vcpus
Keywords:
Status: CLOSED DUPLICATE of bug 1741658
Alias: None
Product: Red Hat Enterprise Linux Advanced Virtualization
Classification: Red Hat
Component: libvirt
Version: 8.1
Hardware: x86_64
OS: Linux
high
unspecified
Target Milestone: rc
: ---
Assignee: Libvirt Maintainers
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On: 1741451
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-08-16 07:23 UTC by Miroslav Rezanina
Modified: 2019-08-16 07:29 UTC (History)
14 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1741451
Environment:
Last Closed: 2019-08-16 07:29:26 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Comment 1 Miroslav Rezanina 2019-08-16 07:25:11 UTC
To highlight, comment by Eduardo:

It looks like libvirt isn't following the expected interface for CPU hotplug.  Understadable, as the documentation is sparse, and the paragraph below is easy to miss.

Documentation for CpuInstanceProperties says:

# Note: currently there are 5 properties that could be present
# but management should be prepared to pass through other
# properties with device_add command to allow for future
# interface extension. This also requires the filed names to be kept in
# sync with the properties passed to -device/device_add.

If query-hotpluggable-cpus returns die-id=0 (which is the case in QEMU 4.1), libvirt should include die-id=0 in -device and device_add.

We could make the interface a bit more flexible, though, and make die-id optional if there's only one possible value for it.

I will submit a patch to QEMU upstream to make it more flexible, but I suggest we also change libvirt to follow the quoted paragraph above, and copy every single property from query-hotpluggable-cpus[].props.

Comment 2 Jiri Denemark 2019-08-16 07:29:26 UTC

*** This bug has been marked as a duplicate of bug 1741658 ***


Note You need to log in before you can comment on or make changes to this bug.