Red Hat Bugzilla – Bug 174181
Review Request: python-simpy Python simulation framework
Last modified: 2007-11-30 17:11:17 EST
Spec Name or Url: http://gallagher.di.uoa.gr/rpms/python-simpy/python-simpy.spec
SRPM Name or Url: http://gallagher.di.uoa.gr/rpms/python-simpy/python-simpy-1.6.1-1.src.rpm
SimPy (= Simulation in Python) is an object-oriented, process-based
discrete-event simulation language based on standard Python. It
provides the modeler with components of a simulation model including
processes, for active components like customers, messages, and
vehicles, and resources, for passive components that form limited
capacity congestion points like servers, checkout counters, and
tunnels. It also provides monitor variables to aid in gathering
statistics. Random variates are provided by the standard Python random
SimGUI doesn't work, rpm isn't picking up that it needs Tkinter. Requires:
The spec file doesn't seem to be encoded in ASCII or URF-8. Please save in one
or the other. file says "python-simpy.spec: lex description text"
Follows python spec template
- rpmlint does not output anything
I would not call this python-simpy, simpy is sufficient, as it is not a python
extension but a SIMulation in PYthon. Debian seems to call it python-simpy,
however. Your choice.
You removed the source documentation. Consider packaging it as a seperate docs
The patch removes all shebangs. Why, is this to quiet rpmlint?
- license (LGPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on FC4 i386, is noarch
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- nothing in %doc affects runtime
- no need for .desktop file
(In reply to comment #1)
> SimGUI doesn't work, rpm isn't picking up that it needs Tkinter. Requires:
> tkinter needed.
> The spec file doesn't seem to be encoded in ASCII or URF-8. Please save in one
> or the other. file says "python-simpy.spec: lex description text"
It is ASCII though. file -i says
python-simpy.spec: text/x-java; charset=us-ascii
I think the first lines confuse the guessing done by file's logic.
> - rpmlint does not output anything
> I would not call this python-simpy, simpy is sufficient, as it is not a python
> extension but a SIMulation in PYthon. Debian seems to call it python-simpy,
> however. Your choice.
It is not a standalone application, but a simulation framework. One writes
simulations in python using this framework, so I think I'll keep the name.
> You removed the source documentation. Consider packaging it as a seperate docs
> The patch removes all shebangs. Why, is this to quiet rpmlint?
Yes. I have no strong feelings on this, I can remove it. The modules from
which the shebangs are removed are not supposed to be executed directly, and
some example scripts I wrote did not show any problems with this patch.
I'll take it upstream anyway to see what the authors think.
Thanks for the review.
Looks good. APPROVED.
Imported to CVS, packages built for FC-3, FC-4 and devel. Closing.