Description of problem: enableUnidling takes a boolean value true or false. When false, it should not allow services to get un-idled. Found out that services are getting un-idled even post setting up this flag on running cluster. Check additional info for CNO config on running cluster


Version-Release number of selected component (if applicable): 4.2.0-0.nightly-2019-08-15-142751

How reproducible: Always


Steps to Reproduce:

$ oc project test
 
$ oc get pods
NAME            READY   STATUS    RESTARTS   AGE
hello-pod       1/1     Running   0          21m
test-rc-bqx6c   1/1     Running   0          66s
test-rc-ns5hr   1/1     Running   0          66s
 
$ oc get svc
NAME           TYPE        CLUSTER-IP      EXTERNAL-IP   PORT(S)     AGE
test-service   ClusterIP   172.30.124.10   <none>        27017/TCP   23h
 
$ oc idle test-service
WARNING: idling when network policies are in place may cause connections to bypass network policy entirely
The service "test/test-service" has been marked as idled
The service will unidle ReplicationController "test/test-rc" to 2 replicas once it receives traffic
ReplicationController "test/test-rc" has been idled
 
$ oc get pods
NAME            READY   STATUS        RESTARTS   AGE
hello-pod       1/1     Running       0          32m
test-rc-4hvbc   0/1     Terminating   0          93s  <<<<<<<<<< Idling svc terminated these pods
test-rc-hshf5   0/1     Terminating   0          93s  <<<<<<<<<< Idling svc terminated these pods
 
 
$ oc rsh hello-pod
/ # curl 172.30.124.10:27017
Hello OpenShift!
/ # exit

$ oc get pods
NAME            READY   STATUS        RESTARTS   AGE
hello-pod       1/1     Running       0          32m
test-rc-4hvb6   1/1     Running       0          13s 
test-rc-hshf7   1/1     Running       0          13s  


Actual results:enableUnidling: false allows svc to unidle

Expected results: enableUnidling: false should not allow svc to unidle

Additional info:

CNO config
 
$ oc get networks.operator.openshift.io -oyaml
apiVersion: v1
items:
- apiVersion: operator.openshift.io/v1
  kind: Network
  metadata:
    creationTimestamp: "2019-08-14T20:17:48Z"
    generation: 8
    name: cluster
    resourceVersion: "380539"
    selfLink: /apis/operator.openshift.io/v1/networks/cluster
    uid: 95795691-bed0-11e9-97e5-02a7493b454c
  spec:
    clusterNetwork:
    - cidr: 10.128.0.0/14
      hostPrefix: 23
    defaultNetwork:
      type: OpenShiftSDN
    openshiftSDNConfig:
      enableUnidling: false  <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< false
    serviceNetwork:
    - 172.30.0.0/16
  status: {}
kind: List
metadata:
  resourceVersion: ""
  selfLink: ""