Red Hat Bugzilla – Bug 174328
Review Request: tklib - a set of useful packages for Tk
Last modified: 2007-11-30 17:11:18 EST
Spec Name or Url: http://www.kobold.org/~wart/fedora/tklib.spec
SRPM Name or Url: http://www.kobold.org/~wart/fedora/tklib-0.4.1-1.src.rpm
Tklib is a set of packages for Tk. Packages include tooltip management and some useful widgets. This is the Tk analog to the tcllib package for Tcl.
This should be a pretty quick review since the package is simple and noarch.
This package provides "make check" possibility, therefore it must be done (in
the special %check section of the spec file).
For me (under FC3) "make check" fails.
Probably it is caused by absence of the files in the normal install path (the
files are present under $RPM_BUILD_ROOT at the check time). Probably something
Anyway, try to provide "make check" success at rpmbuild time.
The "make check" failure is caused by a bug in the script that actually performs
the check. Here is a new package that fixes the bug and adds the %check section
to the spec file.
Patch has been submitted upstream.
I'm not sure if this provides anything useful, though. I took a closer look at
the script that performs the check, and it will always exit with code '0' unless
there is an error in the script itself or if it was invoked with invalid
arguments. If any of the checks fail, it will still return with exit code '0'.
Remarks & nitpicks:
- spec file should not have execution bit set ("chmod -x tklib.spec")
- patch filename should have the upstream version included (for the moment the
patch is appeared), i.e. tklib-0.4.1-makecheck.patch
- remove leading "A" from the Summary field.
- add "rm -rf $RPM_BUILD_ROOT" into the beginning of %install section.
- IMHO it is a little more robust to use wildcards in the %files section.
Created attachment 121739 [details]
Suggested changes for the spec file
I won't argue with any of the suggestions, but I do agree that they are nitpicks. :)
Here's the next attempt:
MUST/SHOULD items OK