Bug 1743298 - Review Request: perl-Test2-Plugin-DBIProfile - Test2 plugin to enable and display DBI profiling
Summary: Review Request: perl-Test2-Plugin-DBIProfile - Test2 plugin to enable and dis...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-08-19 14:57 UTC by Petr Pisar
Modified: 2019-08-26 12:39 UTC (History)
2 users (show)

Fixed In Version: perl-Test2-Plugin-DBIProfile-0.2.2-1.fc32
Clone Of:
Environment:
Last Closed: 2019-08-26 12:39:39 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2019-08-19 14:57:54 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Test2-Plugin-DBIProfile/perl-Test2-Plugin-DBIProfile.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Test2-Plugin-DBIProfile/perl-Test2-Plugin-DBIProfile-0.2.1-1.fc32.src.rpm
Description:
This Test2 plugin enables DBI::Profile globally so that DBI profiling data is
collected. Once testing is complete an event will be produced which contains
and displays the profiling data.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2019-08-20 09:40:36 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Test2-Plugin-DBIProfile-0.2.1-1.fc32.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(DBI::Profile)
      1 perl(:MODULE_COMPAT_5.30.0)
      1 perl(strict)
      1 perl(Test2::API) >= 1.302165
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-Test2-Plugin-DBIProfile-0.2.1-1.fc32.noarch.rpm | sort | uniq -c
      1 perl(Test2::Plugin::DBIProfile) = 0.002001
      1 perl-Test2-Plugin-DBIProfile = 0.2.1-1.fc32
Binary provides are Ok.

$ rpmlint ./perl-Test2-Plugin-DBIProfile*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

FIX: The latest version is 0.002002, please update it before submit.

Please correct 'FIX' issue.

Resolution:
Approved

Comment 2 Petr Pisar 2019-08-21 14:13:15 UTC
Rel-engs have difficulties with creating this package <https://pagure.io/releng/issue/8660>.

Comment 3 Petr Pisar 2019-08-26 12:39:39 UTC
Thank you for the review and the repository. I upgraded the package.


Note You need to log in before you can comment on or make changes to this bug.