Spec URL: http://declera.com/~yaneti/edid-decode/edid-decode.spec SRPM URL: http://declera.com/~yaneti/edid-decode/edid-decode-0-1.20190820git0932deee.fc32.src.rpm Description: Decodes raw monitor EDID data in human-readable format Fedora Account System Username: yaneti This is a split from xorg-x11-utils following the upstream move to linuxtv.org
https://src.fedoraproject.org/rpms/xorg-x11-utils/pull-request/1
You'll need to add Conflicts and/or relevant Requires when splitting packages: https://docs.fedoraproject.org/en-US/packaging-guidelines/Conflicts/#_splitting_packages
- Any reason not to use %make_build? Are there failures with parallel make? Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 26 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/edid- decode/review-edid-decode/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in edid- decode [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: edid-decode-0-1.20190820git0932deee.fc32.x86_64.rpm edid-decode-debuginfo-0-1.20190820git0932deee.fc32.x86_64.rpm edid-decode-debugsource-0-1.20190820git0932deee.fc32.x86_64.rpm edid-decode-0-1.20190820git0932deee.fc32.src.rpm edid-decode.src: W: invalid-url Source0: edid-decode-0932deee.tar.xz 4 packages and 0 specfiles checked; 0 errors, 1 warnings.
Thanks for looking into it. (In reply to Elliott Sales de Andrade from comment #2) > You'll need to add Conflicts The split (and this whole review) is contingent on ajax accepting the merge request and doing a build without edid-decode. If that happens I'll add the Conflicts to xorg-x11-utils (In reply to Robert-André Mauchin from comment #3) > - Any reason not to use %make_build? Are there failures with parallel make? Its one source file .. not much to do in parallel here. But I can change it before import.
Assuming you have talked about this with ajax and that you'll add a Conflicts: , I'll approve this package.
(In reply to Yanko Kaneti from comment #4) > Thanks for looking into it. > > (In reply to Elliott Sales de Andrade from comment #2) > > You'll need to add Conflicts > > The split (and this whole review) is contingent on ajax accepting the merge > request and doing a build without edid-decode. If that happens I'll add the > Conflicts to xorg-x11-utils > No, that doesn't make any sense. dnf can just decide to pick and older version of xorg-x11-utils and edid-decode, and then there will be an implicit file conflict on the contents. The Conflicts must be on the split out package so it can't be installed with the existing one.
What I meant is that I am not going to be requesting the new package if the xorg-x11-utils doesn't drop it. If they do I'll include a specific < versioned conflict.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/edid-decode
Imported. Added Conflicts. Built in rawhide Thanks everyone