Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-gobuffalo-packr.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-gobuffalo-packr-2.5.2-1.fc32.src.rpm Description: Packr is a simple solution for bundling static assets inside of Go binaries. Most importantly it does it in a way that is friendly to developers while they are developing. Fedora Account System Username: eclipseo
COPR build: https://copr.fedorainfracloud.org/coprs/build/1011605
Latest version is 2.6.0. One file appears to be ASL 2.0, which may have been an accident and you might want to report that upstream. This is actually a correctly implemented v2 with it contained in a separate subdirectory. This means your -devel package actually provides both v1 (no suffix) and v2 import paths, and go.mods, etc.. I'm not sure if that means they should be placed into their own separate subpackages. It shold provide two golang-ipath, I think. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [!]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated", "Expat License", "Apache License (v2.0)". 163 files have unknown license. Detailed output of licensecheck in 1744144-golang-github-gobuffalo-packr/licensecheck.txt [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [?]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 16 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: golang-github-gobuffalo-packr-2.5.2-1.fc32.src.rpm golang-github-gobuffalo-packr.src: W: no-%build-section golang-github-gobuffalo-packr.src: E: specfile-error warning: -u use in %forgemeta is deprecated, use -z instead to select a separate set of rpm variables! 1 packages and 0 specfiles checked; 1 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- golang-github-gobuffalo-packr-devel.noarch: E: zero-length /usr/share/doc/golang-github-gobuffalo-packr-devel/example/bar/bar.html golang-github-gobuffalo-packr-devel.noarch: E: zero-length /usr/share/doc/golang-github-gobuffalo-packr-devel/example/bar/sub/sub.html golang-github-gobuffalo-packr-devel.noarch: E: zero-length /usr/share/doc/golang-github-gobuffalo-packr-devel/example/baz/baz.html golang-github-gobuffalo-packr-devel.noarch: E: zero-length /usr/share/doc/golang-github-gobuffalo-packr-devel/example/constant/constant.html golang-github-gobuffalo-packr-devel.noarch: E: zero-length /usr/share/doc/golang-github-gobuffalo-packr-devel/example/variable/variable.html golang-github-gobuffalo-packr-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/gobuffalo/packr/.goipath 1 packages and 0 specfiles checked; 5 errors, 1 warnings. Source checksums ---------------- https://github.com/gobuffalo/packr/archive/v2.5.2/packr-2.5.2.tar.gz : CHECKSUM(SHA256) this package : f638340c1bb4f671ab5a101969a2e63fe11300cf9ead0f481a8c3e0ab966a423 CHECKSUM(SHA256) upstream package : f638340c1bb4f671ab5a101969a2e63fe11300cf9ead0f481a8c3e0ab966a423 Requires -------- go-filesystem golang(github.com/gobuffalo/envy) golang(github.com/gobuffalo/logger) golang(github.com/gobuffalo/packd) golang(github.com/karrick/godirwalk) golang(github.com/rogpeppe/go-internal/modfile) golang(github.com/sirupsen/logrus) golang(github.com/spf13/cobra) golang(golang.org/x/sync/errgroup) golang(golang.org/x/tools/go/ast/astutil) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Provides -------- golang(github.com/gobuffalo/packr) = 2.5.2-1.fc32 golang(github.com/gobuffalo/packr/builder) = 2.5.2-1.fc32 golang(github.com/gobuffalo/packr/packr/cmd) = 2.5.2-1.fc32 golang(github.com/gobuffalo/packr/v2) = 2.5.2-1.fc32 golang(github.com/gobuffalo/packr/v2/file) = 2.5.2-1.fc32 golang(github.com/gobuffalo/packr/v2/file/resolver) = 2.5.2-1.fc32 golang(github.com/gobuffalo/packr/v2/file/resolver/encoding/hex) = 2.5.2-1.fc32 golang(github.com/gobuffalo/packr/v2/internal/takeon/github.com/markbates/errx) = 2.5.2-1.fc32 golang(github.com/gobuffalo/packr/v2/internal/takeon/github.com/markbates/oncer) = 2.5.2-1.fc32 golang(github.com/gobuffalo/packr/v2/internal/takeon/github.com/markbates/safe) = 2.5.2-1.fc32 golang(github.com/gobuffalo/packr/v2/jam) = 2.5.2-1.fc32 golang(github.com/gobuffalo/packr/v2/jam/parser) = 2.5.2-1.fc32 golang(github.com/gobuffalo/packr/v2/jam/store) = 2.5.2-1.fc32 golang(github.com/gobuffalo/packr/v2/packr2/cmd) = 2.5.2-1.fc32 golang(github.com/gobuffalo/packr/v2/packr2/cmd/fix) = 2.5.2-1.fc32 golang(github.com/gobuffalo/packr/v2/plog) = 2.5.2-1.fc32 golang-github-gobuffalo-packr-devel = 2.5.2-1.fc32 golang-ipath(github.com/gobuffalo/packr) = 2.5.2-1.fc32 Generated by fedora-review 0.7.2 (65d36bb) last change: 2019-04-09 Command line :/usr/bin/fedora-review -b 1744144 -m fedora-rawhide-x86_64 -L packr/ Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: fonts, SugarActivity, Java, R, PHP, Haskell, C/C++, Ocaml, Python, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Built with local dependencies: packr/golang-github-gobuffalo-logger-devel-1.0.1-1.fc32.noarch.rpm packr/golang-github-gobuffalo-packd-devel-0.3.0-1.fc32.noarch.rpm
New Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-gobuffalo-packr.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-gobuffalo-packr-2.6.0-1.fc32.src.rpm
Splitted the package in 2 with: %global goipaths0 github.com/gobuffalo/packr %global goipathsex0 github.com/gobuffalo/packr/v2 %global goipaths1 github.com/gobuffalo/packr/v2 And asked upstream about the license: https://github.com/gobuffalo/packr/issues/239
(In reply to Robert-André Mauchin from comment #4) > Splitted the package in 2 with: > > %global goipaths0 github.com/gobuffalo/packr > %global goipathsex0 github.com/gobuffalo/packr/v2 > %global goipaths1 github.com/gobuffalo/packr/v2 > > And asked upstream about the license: > https://github.com/gobuffalo/packr/issues/239 ASL 2.0 confirmed as error: https://github.com/gobuffalo/packr/issues/239#issuecomment-530470138
Please import your other reviews; the scratch builds for the other approved packages have been garbage collected.
Most packages have been imported.
Looks good now.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-gobuffalo-packr
FEDORA-2019-8154a87b30 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-8154a87b30
golang-github-gobuffalo-packr-2.6.0-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-8154a87b30
golang-github-gobuffalo-packr-2.6.0-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.