Spec Name or Url: http://fedora.lowlatency.de/review/wine-docs.spec SRPM Name or Url: http://fedora.lowlatency.de/review/wine-docs-0.9.2-1.src.rpm Description: This package is Wine's documentation repository. It consists of various guides and their translations.
New version: http://fedora.lowlatency.de/review/wine-docs.spec http://fedora.lowlatency.de/review/wine-docs-0.9.3-1.src.rpm
New version: http://fedora.lowlatency.de/review/wine-docs.spec http://fedora.lowlatency.de/review/wine-docs-0.9.4-1.src.rpm
New version: http://fedora.lowlatency.de/review/wine-docs.spec http://fedora.lowlatency.de/review/wine-docs-0.9.5-1.src.rpm
Lint results: # rpmlint wine-docs-0.9.5-1.src.rpm E: wine-docs configure-without-libdir-spec - could be ignored, nothing libbed here. # rpmlint wine-docs-0.9.5-1.noarch.rpm W: wine-docs no-version-in-last-changelog That thing again. Not much to care about here. Docs are placed in /usr/share/doc/wine-docs-0.9.5, perhaps one would prefer /usr/share/doc/wine-0.9.5 but who cares. GOOD: * Package name matches spec file name * Meets package naming guidelines (child package docs) * FLOSS-compatible license (LGPL) * spec file is in american english * spec file is readable indeed * sources match upstream (MD5SUM is the same) * builds fine on FC4 * no exceptionized BuildRequires * all build dependencies listed * no locale magic needed * no libraries installed * non-relocatable * owns its directories (implicit since %doc tag is used) * no duplicate files * proper permissions on files * proper %clean section * proper use of macros I think, should %configure be used instead of ./configure? NEEDSWORK: * License field is wrong: tagged GPL but is LGPL (COPYING.LIB) * The license file MUST be %doc:ed Fix these and it's a go...
Fixed the NEEDSWORK things... as to configure: If I remeber correctly it failed with %configure ... Here you go and thanks for your time :) http://fedora.lowlatency.de/review/wine-docs.spec http://fedora.lowlatency.de/review/wine-docs-0.9.5-2.src.rpm
APPROVED.
Thanks again :) build for fc5.
Package Change Request ====================== Package Name: wine-docs New Branches: EL-5
Package Change Request ====================== Package Name: wine-docs New Branches: EL-4
cvs done.