Bug 1745555 - Disabled buttons are still working
Summary: Disabled buttons are still working
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: WebUI
Version: 6.6.0
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: 6.6.0
Assignee: Ron Lavi
QA Contact: vijsingh
URL:
Whiteboard:
Depends On:
Blocks: 1761872
TreeView+ depends on / blocked
 
Reported: 2019-08-26 11:06 UTC by Peter Dragun
Modified: 2019-10-22 19:52 UTC (History)
7 users (show)

Fixed In Version: foreman-1.22.0.26-1,rubygem-foreman_remote_execution-1.8.0.4-1,foreman-1.22.0.32-1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1761872 (view as bug list)
Environment:
Last Closed: 2019-10-22 19:52:30 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Foreman Issue Tracker 27831 0 Normal Closed Disabled buttons are still working 2020-05-27 14:49:28 UTC
Foreman Issue Tracker 27881 0 Normal Closed Disabled buttons fetched by ajax are still working 2020-05-27 14:49:28 UTC
Foreman Issue Tracker 27883 0 Normal Closed Do not use a[method=post] in jobs toolbar 2020-05-27 14:49:28 UTC
Github theforeman foreman pull 7033 0 None closed Fixes #27813 - disabled buttons all over the app are still clickable 2020-05-27 14:49:27 UTC
Github theforeman foreman pull 7049 0 None closed Fixes #27881 - disabled buttons 2020-05-27 14:49:28 UTC
Github theforeman foreman_remote_execution pull 434 0 None closed Fixes #27883 - use button_to for post links 2020-05-27 14:49:28 UTC

Description Peter Dragun 2019-08-26 11:06:51 UTC
Description of problem:
Even if button is showed as disabled it is clickable and working normally as enabled. Applies to almost every disabled button in UI.

Version-Release number of selected component (if applicable):


How reproducible:
always

Steps to Reproduce:
For example
1. Go to Monitor -> Jobs 
2. Select job, that already run.
3. Buttons 'Cancel Job' and 'Abort Job' are disabled
4. Click on any disabled button

Actual results:
Button works even if, it is disabled. Page is refreshed and warning 'The job cannot be cancelled at the moment.' is shown

Expected results:
Clicking on disabled button does nothing

Additional info:
Found similar behavior in hosts.
In Satellite 6.5 clicking on disabled button does nothing.

Comment 4 Peter Dragun 2019-08-27 08:46:04 UTC
I noticed change of component. Just noting that same behavior is in 'Host details' as I mentioned above, not only in Remote Execution.

Comment 5 Marek Hulan 2019-08-30 16:46:48 UTC
Thanks Peter, I missed that. Reverting to general WebUI then.

Comment 9 Marek Hulan 2019-09-10 15:15:33 UTC
Created redmine issue https://projects.theforeman.org/issues/27813 from this bug

Comment 10 Bryan Kearney 2019-09-12 08:09:11 UTC
Moving this bug to POST for triage into Satellite 6 since the upstream issue https://projects.theforeman.org/issues/27831 has been resolved.

Comment 12 vijsingh 2019-09-17 10:51:55 UTC
ON_QA Failed:

@Satellite 6.6.0 snap 20.1

Steps:

  1. Go to Monitor -> Jobs 
  2. Select job, that already run.
  3. Buttons 'Rerun Failed' , 'Cancel Job' and 'Abort Job' are disabled
  4. Click on any disabled button

Actual results: 

 1. Button works even if, it is disabled. Page is refreshed and warning 'The job cannot be cancelled at the moment.' is shown
 2. 'Rerun Failed' clickable
 3. 'Abort Job' clickable

Comment 25 Ron Lavi 2019-09-24 07:29:00 UTC
I couldn't reproduce the first two - for me they were always disabled,
as for the third, it seem that on the first click it is disabled, and after that it will be enabled.
added a small fix:
- https://projects.theforeman.org/issues/27881
- https://github.com/theforeman/foreman/pull/7063

Comment 26 vijsingh 2019-09-24 08:04:46 UTC
> I couldn't reproduce the first two - for me they were always disabled,
Could you try to run a fresh job and see ?

Comment 27 Ron Lavi 2019-09-24 09:15:25 UTC
Thanks Vijay, I saw it now only when creating,
but after those few seconds they are always disabled.

Comment 29 Ron Lavi 2019-09-24 11:34:22 UTC
Opened a PR to fix the first two issues in foreman_remote_execution: 
- https://projects.theforeman.org/issues/27930
- https://github.com/theforeman/foreman_remote_execution/pull/435

The PR that fixes the 3rd issue is already merged in Foreman: https://projects.theforeman.org/issues/27881

Comment 35 vijsingh 2019-09-24 13:09:21 UTC
ON_QA Verified:

@Satellite 6.6.0 snap 22.0

Steps:

  1. Go to Monitor -> Jobs 
  2. Select job, that already run. or run a new job

Actual results: 

 a. 'Cancel Job' => if the job is running, it can be cancelled and after finish it can't
 b. 'Abort Job' => if the job is running, it can be Aborted and after finish it can't

Comment 36 Bryan Kearney 2019-10-22 19:52:30 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:3172


Note You need to log in before you can comment on or make changes to this bug.