Bug 1745685 - Make hashlib.get_fips_mode() a private function
Summary: Make hashlib.get_fips_mode() a private function
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: python3
Version: 8.1
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: 8.0
Assignee: Python Maintainers
QA Contact: Lukáš Zachar
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-08-26 16:06 UTC by Christian Heimes
Modified: 2019-11-05 22:04 UTC (History)
4 users (show)

Fixed In Version: python3-3.6.8-15.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-11-05 22:03:44 UTC
Type: Bug
Target Upstream Version:


Attachments (Terms of Use)


Links
System ID Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2019:3520 None None None 2019-11-05 22:04:04 UTC

Description Christian Heimes 2019-08-26 16:06:37 UTC
Description of problem:
The patch 00329-fips.patch adds hashlib.get_fips_mode(). Please rename the new function to _get_fips_mode(). It's an internal helper and should not be part of public API for hashlib module.

Version-Release number of selected component (if applicable):
python3-libs-3.6.8-14.el8.x86_64

How reproducible:
always

Comment 1 Petr Viktorin 2019-08-26 17:24:30 UTC
I'm thinking aboutl not re-exporting it from hashlib, and keeping it as _hashlib.get_fips_mode. _hashlib itself is an internal helper.
Does that sound OK?

Comment 2 Christian Heimes 2019-08-26 17:48:01 UTC
Even better!

Does it has to be a function or can you make it an attribute of _hashlib?

Comment 3 Petr Viktorin 2019-08-26 17:50:36 UTC
Ergonomics don't matter for internal helpers, so I'll keep it as a function call.

Comment 12 errata-xmlrpc 2019-11-05 22:03:44 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:3520


Note You need to log in before you can comment on or make changes to this bug.